serv/tube
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix upload error for large files (#71)

Browse source 
This should avoid allocation of max_upload_size bytes of RAM.
Instead we only allocate 1MB of RAM for the upload form decoder.

- Closes #67

Reviewed-on: https://git.mills.io/prologic/tube/pulls/71
Co-authored-by: Heinrich 'Henrik' Langos <gumbo2000@noreply@mills.io>
Co-committed-by: Heinrich 'Henrik' Langos <gumbo2000@noreply@mills.io>
This commit is contained in:
Heinrich 'Henrik' Langos 2023-02-13 22:06:07 +00:00 committed by James Mills
parent 7e6e2a0c1c
commit e14f19abd3
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/app.go
View file

@ -42,6 +42,9 @@ type App struct {
Router *mux.Router Router *mux.Router
} }
// 1MB buffer in RAM seems enough
const uploadParserBuffer = 1_048_576
// NewApp returns a new instance of App from Config. // NewApp returns a new instance of App from Config.
func NewApp(cfg *Config) (*App, error) { func NewApp(cfg *Config) (*App, error) {
if cfg == nil { if cfg == nil {
@ -234,7 +237,7 @@ func (a *App) uploadHandler(w http.ResponseWriter, r *http.Request) {
} }
a.render("upload", w, ctx) a.render("upload", w, ctx)
} else if r.Method == "POST" { } else if r.Method == "POST" {
r.ParseMultipartForm(a.Config.Server.MaxUploadSize) r.ParseMultipartForm(uploadParserBuffer)
file, handler, err := r.FormFile("video_file") file, handler, err := r.FormFile("video_file")
if err != nil { if err != nil {