serv/tube
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove direct library add after upload as Rename(s) are not atomic on some file systems

Browse source
This commit is contained in:
James Mills 2020-03-22 18:31:24 +10:00
parent e2381cc2ab
commit a7e88fbcac
No known key found for this signature in database
GPG key ID: AC4C014F1440EBD6
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/app.go
View file

@ -240,13 +240,6 @@ func (a *App) uploadHandler(w http.ResponseWriter, r *http.Request) {
os.Rename(tf.Name(), of) os.Rename(tf.Name(), of)
os.Remove(fn) os.Remove(fn)
if err := a.Library.Add(of); err != nil {
err := fmt.Errorf("error adding new video: %w", err)
log.Error(err)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
fmt.Fprintf(w, "Video successfully uploaded!") fmt.Fprintf(w, "Video successfully uploaded!")
} else { } else {
http.Error(w, "Method Not Allowed", http.StatusMethodNotAllowed) http.Error(w, "Method Not Allowed", http.StatusMethodNotAllowed)