mox/store/state.go
Mechiel Lukkien e943e0c65d
fix delay with propagating mailbox changes to other imap (idle) connections
when broadcasting a change, we would try to send the changes on a channel,
non-blocking. if we couldn't send (because there was no pending blocked
receive), we would wait until the potential receiver would explicitly request
the changes. however, the imap idle handler would not explicitly request the
changes, but do a receive on the changes channel. since there was no pending
blocked send on the channel, that receive would block. only when another event
would come in, would both the pending and the new changes be sent.

we now use a channel only for signaling there are pending changes. the channel
is buffered, so when broadcasting we can just set the signal by a non-blocking
send and continue with the next listener. the receiver will get the buffered
signal. it can then get the changes directly, but lock-protected.

found when looking at a missing/delayed new message notification in thunderbird
when two messages arrive immediately after each other. this doesn't fix that
problem though: it seems thunderbird just ignores imap untagged "exists"
messages (indicating a new message arrived) during the "uid fetch" command that
it issued after notifications from an "idle" command.
2023-07-23 15:28:37 +02:00

184 lines
4 KiB
Go

package store
import (
"sync"
"sync/atomic"
)
var (
register = make(chan *Comm)
unregister = make(chan *Comm)
broadcast = make(chan changeReq)
)
type changeReq struct {
acc *Account
comm *Comm // Can be nil.
changes []Change
done chan struct{}
}
type UID uint32 // IMAP UID.
// Change to mailboxes/subscriptions/messages in an account. One of the Change*
// types in this package.
type Change any
// ChangeAddUID is sent for a new message in a mailbox.
type ChangeAddUID struct {
MailboxID int64
UID UID
Flags Flags // System flags.
Keywords []string // Other flags.
}
// ChangeRemoveUIDs is sent for removal of one or more messages from a mailbox.
type ChangeRemoveUIDs struct {
MailboxID int64
UIDs []UID
}
// ChangeFlags is sent for an update to flags for a message, e.g. "Seen".
type ChangeFlags struct {
MailboxID int64
UID UID
Mask Flags // Which flags are actually modified.
Flags Flags // New flag values. All are set, not just mask.
Keywords []string // Other flags.
}
// ChangeRemoveMailbox is sent for a removed mailbox.
type ChangeRemoveMailbox struct {
Name string
}
// ChangeAddMailbox is sent for a newly created mailbox.
type ChangeAddMailbox struct {
Name string
Flags []string
}
// ChangeRenameMailbox is sent for a rename mailbox.
type ChangeRenameMailbox struct {
OldName string
NewName string
Flags []string
}
// ChangeAddSubscription is sent for an added subscription to a mailbox.
type ChangeAddSubscription struct {
Name string
}
var switchboardBusy atomic.Bool
// Switchboard distributes changes to accounts to interested listeners. See Comm and Change.
func Switchboard() chan struct{} {
regs := map[*Account]map[*Comm]struct{}{}
done := make(chan struct{})
if !switchboardBusy.CompareAndSwap(false, true) {
panic("switchboard already busy")
}
go func() {
for {
select {
case c := <-register:
if _, ok := regs[c.acc]; !ok {
regs[c.acc] = map[*Comm]struct{}{}
}
regs[c.acc][c] = struct{}{}
case c := <-unregister:
delete(regs[c.acc], c)
if len(regs[c.acc]) == 0 {
delete(regs, c.acc)
}
case chReq := <-broadcast:
acc := chReq.acc
for c := range regs[acc] {
// Do not send the broadcaster back their own changes. chReq.comm is nil if not
// originating from a comm, so won't match in that case.
if c == chReq.comm {
continue
}
c.Lock()
c.changes = append(c.changes, chReq.changes...)
c.Unlock()
select {
case c.Pending <- struct{}{}:
default:
}
}
chReq.done <- struct{}{}
case <-done:
if !switchboardBusy.CompareAndSwap(true, false) {
panic("switchboard already unregistered?")
}
return
}
}
}()
return done
}
// Comm handles communication with the goroutine that maintains the
// account/mailbox/message state.
type Comm struct {
Pending chan struct{} // Receives block until changes come in, e.g. for IMAP IDLE.
acc *Account
sync.Mutex
changes []Change
}
// Register starts a Comm for the account. Unregister must be called.
func RegisterComm(acc *Account) *Comm {
c := &Comm{
Pending: make(chan struct{}, 1), // Bufferend so Switchboard can just do a non-blocking send.
acc: acc,
}
register <- c
return c
}
// Unregister stops this Comm.
func (c *Comm) Unregister() {
unregister <- c
}
// Broadcast ensures changes are sent to other Comms.
func (c *Comm) Broadcast(ch []Change) {
if len(ch) == 0 {
return
}
done := make(chan struct{}, 1)
broadcast <- changeReq{c.acc, c, ch, done}
<-done
}
// Get retrieves all pending changes. If no changes are pending a nil or empty list
// is returned.
func (c *Comm) Get() []Change {
c.Lock()
defer c.Unlock()
l := c.changes
c.changes = nil
return l
}
// BroadcastChanges ensures changes are sent to all listeners on the accoount.
func BroadcastChanges(acc *Account, ch []Change) {
if len(ch) == 0 {
return
}
done := make(chan struct{}, 1)
broadcast <- changeReq{acc, nil, ch, done}
<-done
}