mirror of
https://github.com/mjl-/mox.git
synced 2025-01-03 20:33:09 +03:00
0f8bf2f220
the http basic auth we had was very simple to reason about, and to implement. but it has a major downside: there is no way to logout, browsers keep sending credentials. ideally, browsers themselves would show a button to stop sending credentials. a related downside: the http auth mechanism doesn't indicate for which server paths the credentials are. another downside: the original password is sent to the server with each request. though sending original passwords to web servers seems to be considered normal. our new approach uses session cookies, along with csrf values when we can. the sessions are server-side managed, automatically extended on each use. this makes it easy to invalidate sessions and keeps the frontend simpler (than with long- vs short-term sessions and refreshing). the cookies are httponly, samesite=strict, scoped to the path of the web interface. cookies are set "secure" when set over https. the cookie is set by a successful call to Login. a call to Logout invalidates a session. changing a password invalidates all sessions for a user, but keeps the session with which the password was changed alive. the csrf value is also random, and associated with the session cookie. the csrf must be sent as header for api calls, or as parameter for direct form posts (where we cannot set a custom header). rest-like calls made directly by the browser, e.g. for images, don't have a csrf protection. the csrf value is returned by the Login api call and stored in localstorage. api calls without credentials return code "user:noAuth", and with bad credentials return "user:badAuth". the api client recognizes this and triggers a login. after a login, all auth-failed api calls are automatically retried. only for "user:badAuth" is an error message displayed in the login form (e.g. session expired). in an ideal world, browsers would take care of most session management. a server would indicate authentication is needed (like http basic auth), and the browsers uses trusted ui to request credentials for the server & path. the browser could use safer mechanism than sending original passwords to the server, such as scram, along with a standard way to create sessions. for now, web developers have to do authentication themselves: from showing the login prompt, ensuring the right session/csrf cookies/localstorage/headers/etc are sent with each request. webauthn is a newer way to do authentication, perhaps we'll implement it in the future. though hardware tokens aren't an attractive option for many users, and it may be overkill as long as we still do old-fashioned authentication in smtp & imap where passwords can be sent to the server. for issue #58
458 lines
11 KiB
Go
458 lines
11 KiB
Go
package bstore
|
|
|
|
import (
|
|
"fmt"
|
|
"math"
|
|
"reflect"
|
|
"strconv"
|
|
"time"
|
|
|
|
bolt "go.etcd.io/bbolt"
|
|
)
|
|
|
|
// Types returns the types present in the database, regardless of whether they
|
|
// are currently registered using Open or Register. Useful for exporting data
|
|
// with Keys and Records.
|
|
func (tx *Tx) Types() ([]string, error) {
|
|
if err := tx.ctx.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var types []string
|
|
err := tx.btx.ForEach(func(bname []byte, b *bolt.Bucket) error {
|
|
// note: we do not track stats for types operations.
|
|
|
|
types = append(types, string(bname))
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return types, nil
|
|
}
|
|
|
|
// prepareType prepares typeName for export/introspection with DB.Keys,
|
|
// DB.Record, DB.Records. It is different in that it does not require a
|
|
// reflect.Type to parse into. It parses to a map, e.g. for export to JSON.
|
|
func (db *DB) prepareType(tx *Tx, typeName string) (map[uint32]*typeVersion, *typeVersion, *bolt.Bucket, []string, error) {
|
|
if err := tx.ctx.Err(); err != nil {
|
|
return nil, nil, nil, nil, err
|
|
}
|
|
|
|
rb, err := tx.recordsBucket(typeName, 0.5)
|
|
if err != nil {
|
|
return nil, nil, nil, nil, err
|
|
}
|
|
tb, err := tx.bucket(bucketKey{typeName, "types"})
|
|
if err != nil {
|
|
return nil, nil, nil, nil, err
|
|
}
|
|
versions := map[uint32]*typeVersion{}
|
|
var tv *typeVersion
|
|
err = tb.ForEach(func(bk, bv []byte) error {
|
|
// note: we do not track stats for types operations.
|
|
|
|
ntv, err := parseSchema(bk, bv)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
versions[ntv.Version] = ntv
|
|
if tv == nil || ntv.Version > tv.Version {
|
|
tv = ntv
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, nil, nil, nil, err
|
|
}
|
|
if tv == nil {
|
|
return nil, nil, nil, nil, fmt.Errorf("%w: no type versions", ErrStore)
|
|
}
|
|
fields := make([]string, len(tv.Fields))
|
|
for i, f := range tv.Fields {
|
|
fields[i] = f.Name
|
|
}
|
|
return versions, tv, rb, fields, nil
|
|
}
|
|
|
|
// Keys returns the parsed primary keys for the type "typeName". The type does
|
|
// not have to be registered with Open or Register. For use with Record(s) to
|
|
// export data.
|
|
func (tx *Tx) Keys(typeName string, fn func(pk any) error) error {
|
|
_, tv, rb, _, err := tx.db.prepareType(tx, typeName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
ctxDone := tx.ctx.Done()
|
|
|
|
v := reflect.New(reflect.TypeOf(tv.Fields[0].Type.zeroKey())).Elem()
|
|
return rb.ForEach(func(bk, bv []byte) error {
|
|
tx.stats.Records.Cursor++
|
|
|
|
select {
|
|
case <-ctxDone:
|
|
return tx.ctx.Err()
|
|
default:
|
|
}
|
|
|
|
if err := parsePK(v, bk); err != nil {
|
|
return err
|
|
}
|
|
return fn(v.Interface())
|
|
})
|
|
}
|
|
|
|
// Record returns the record with primary "key" for "typeName" parsed as map.
|
|
// "Fields" is set to the fields of the type. The type does not have to be
|
|
// registered with Open or Register. Record parses the data without the Go
|
|
// type present. BinaryMarshal fields are returned as bytes.
|
|
func (tx *Tx) Record(typeName, key string, fields *[]string) (map[string]any, error) {
|
|
versions, tv, rb, xfields, err := tx.db.prepareType(tx, typeName)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
*fields = xfields
|
|
|
|
var kv any
|
|
switch tv.Fields[0].Type.Kind {
|
|
case kindBool:
|
|
switch key {
|
|
case "true":
|
|
kv = true
|
|
case "false":
|
|
kv = false
|
|
default:
|
|
err = fmt.Errorf("%w: invalid bool %q", ErrParam, key)
|
|
}
|
|
case kindInt8:
|
|
kv, err = strconv.ParseInt(key, 10, 8)
|
|
case kindInt16:
|
|
kv, err = strconv.ParseInt(key, 10, 16)
|
|
case kindInt32:
|
|
kv, err = strconv.ParseInt(key, 10, 32)
|
|
case kindInt:
|
|
kv, err = strconv.ParseInt(key, 10, 32)
|
|
case kindInt64:
|
|
kv, err = strconv.ParseInt(key, 10, 64)
|
|
case kindUint8:
|
|
kv, err = strconv.ParseUint(key, 10, 8)
|
|
case kindUint16:
|
|
kv, err = strconv.ParseUint(key, 10, 16)
|
|
case kindUint32:
|
|
kv, err = strconv.ParseUint(key, 10, 32)
|
|
case kindUint:
|
|
kv, err = strconv.ParseUint(key, 10, 32)
|
|
case kindUint64:
|
|
kv, err = strconv.ParseUint(key, 10, 64)
|
|
case kindString:
|
|
kv = key
|
|
case kindBytes:
|
|
kv = []byte(key) // todo: or decode from base64?
|
|
default:
|
|
return nil, fmt.Errorf("internal error: unknown primary key kind %v", tv.Fields[0].Type.Kind)
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pkv := reflect.ValueOf(kv)
|
|
k, err := typeKind(pkv.Type())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if k != tv.Fields[0].Type.Kind {
|
|
// Convert from various int types above to required type. The ParseInt/ParseUint
|
|
// calls already validated that the values fit.
|
|
pkt := reflect.TypeOf(tv.Fields[0].Type.zeroKey())
|
|
pkv = pkv.Convert(pkt)
|
|
}
|
|
pk, err := packPK(pkv)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
tx.stats.Records.Get++
|
|
bv := rb.Get(pk)
|
|
if bv == nil {
|
|
return nil, ErrAbsent
|
|
}
|
|
record, err := parseMap(versions, pk, bv)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return record, nil
|
|
}
|
|
|
|
// Records calls "fn" for each record of "typeName". Records sets "fields" to
|
|
// the fields of the type. The type does not have to be registered with Open or
|
|
// Register. Record parses the data without the Go type present. BinaryMarshal
|
|
// fields are returned as bytes.
|
|
func (tx *Tx) Records(typeName string, fields *[]string, fn func(map[string]any) error) error {
|
|
versions, _, rb, xfields, err := tx.db.prepareType(tx, typeName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
*fields = xfields
|
|
|
|
ctxDone := tx.ctx.Done()
|
|
|
|
return rb.ForEach(func(bk, bv []byte) error {
|
|
tx.stats.Records.Cursor++
|
|
|
|
select {
|
|
case <-ctxDone:
|
|
return tx.ctx.Err()
|
|
default:
|
|
}
|
|
|
|
record, err := parseMap(versions, bk, bv)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return fn(record)
|
|
})
|
|
}
|
|
|
|
// parseMap parses a record into a map with the right typeVersion from versions.
|
|
func parseMap(versions map[uint32]*typeVersion, bk, bv []byte) (record map[string]any, rerr error) {
|
|
p := &parser{buf: bv, orig: bv}
|
|
var version uint32
|
|
|
|
defer func() {
|
|
x := recover()
|
|
if x == nil {
|
|
return
|
|
}
|
|
if err, ok := x.(parseErr); ok {
|
|
rerr = fmt.Errorf("%w (version %d, buf %x orig %x)", err.err, version, p.buf, p.orig)
|
|
return
|
|
}
|
|
panic(x)
|
|
}()
|
|
|
|
version = uint32(p.Uvarint())
|
|
tv := versions[version]
|
|
if tv == nil {
|
|
return nil, fmt.Errorf("%w: unknown type version %d", ErrStore, version)
|
|
}
|
|
|
|
r := map[string]any{}
|
|
|
|
v := reflect.New(reflect.TypeOf(tv.Fields[0].Type.zeroKey())).Elem()
|
|
err := parsePK(v, bk)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
r[tv.Fields[0].Name] = v.Interface()
|
|
|
|
// todo: Should we be looking at the most recent tv, and hiding fields
|
|
// that have been removed in a later typeVersion? Like we do for real
|
|
// parsing into reflect value?
|
|
fm := p.Fieldmap(len(tv.Fields) - 1)
|
|
for i, f := range tv.Fields[1:] {
|
|
if fm.Nonzero(i) {
|
|
r[f.Name] = f.Type.parseValue(p)
|
|
} else {
|
|
r[f.Name] = f.Type.zeroExportValue()
|
|
}
|
|
}
|
|
|
|
if len(p.buf) != 0 {
|
|
return nil, fmt.Errorf("%w: leftover data after parsing (%d %x %q)", ErrStore, len(p.buf), p.buf, p.buf)
|
|
}
|
|
|
|
return r, nil
|
|
}
|
|
|
|
func (ft fieldType) parseValue(p *parser) any {
|
|
switch ft.Kind {
|
|
case kindBytes:
|
|
return p.TakeBytes(false)
|
|
case kindBinaryMarshal:
|
|
// We don't have the type available, so we just return the binary data.
|
|
return p.TakeBytes(false)
|
|
case kindBool:
|
|
if !ft.Ptr {
|
|
return true
|
|
}
|
|
buf := p.Take(1)
|
|
return buf[0] != 0
|
|
case kindInt8:
|
|
return int8(p.Varint())
|
|
case kindInt16:
|
|
return int16(p.Varint())
|
|
case kindInt32:
|
|
return int32(p.Varint())
|
|
case kindInt:
|
|
i := p.Varint()
|
|
if i < math.MinInt32 || i > math.MaxInt32 {
|
|
p.Errorf("%w: int %d does not fit in int32", ErrStore, i)
|
|
}
|
|
return int(i)
|
|
case kindInt64:
|
|
return p.Varint()
|
|
case kindUint8:
|
|
return uint8(p.Uvarint())
|
|
case kindUint16:
|
|
return uint16(p.Uvarint())
|
|
case kindUint32:
|
|
return uint32(p.Uvarint())
|
|
case kindUint:
|
|
i := p.Uvarint()
|
|
if i > math.MaxUint32 {
|
|
p.Errorf("%w: uint %d does not fit in uint32", ErrStore, i)
|
|
}
|
|
return uint(i)
|
|
case kindUint64:
|
|
return p.Uvarint()
|
|
case kindFloat32:
|
|
return math.Float32frombits(uint32(p.Uvarint()))
|
|
case kindFloat64:
|
|
return math.Float64frombits(p.Uvarint())
|
|
case kindString:
|
|
return string(p.TakeBytes(false))
|
|
case kindTime:
|
|
var t time.Time
|
|
err := t.UnmarshalBinary(p.TakeBytes(false))
|
|
if err != nil {
|
|
p.Errorf("%w: parsing time: %v", ErrStore, err)
|
|
}
|
|
return t
|
|
case kindSlice:
|
|
un := p.Uvarint()
|
|
n := p.checkInt(un)
|
|
fm := p.Fieldmap(n)
|
|
var l []any
|
|
for i := 0; i < n; i++ {
|
|
if fm.Nonzero(i) {
|
|
l = append(l, ft.ListElem.parseValue(p))
|
|
} else {
|
|
// Always add non-zero elements, or we would
|
|
// change the number of elements in a list.
|
|
l = append(l, ft.ListElem.zeroExportValue())
|
|
}
|
|
}
|
|
return l
|
|
case kindArray:
|
|
n := ft.ArrayLength
|
|
l := make([]any, n)
|
|
fm := p.Fieldmap(n)
|
|
for i := 0; i < n; i++ {
|
|
if fm.Nonzero(i) {
|
|
l[i] = ft.ListElem.parseValue(p)
|
|
} else {
|
|
// Always add non-zero elements, or we would
|
|
// change the number of elements in a list.
|
|
l[i] = ft.ListElem.zeroExportValue()
|
|
}
|
|
}
|
|
return l
|
|
case kindMap:
|
|
un := p.Uvarint()
|
|
n := p.checkInt(un)
|
|
fm := p.Fieldmap(n)
|
|
m := map[string]any{}
|
|
for i := 0; i < n; i++ {
|
|
// Converting to string can be ugly, but the best we can do.
|
|
k := fmt.Sprintf("%v", ft.MapKey.parseValue(p))
|
|
if _, ok := m[k]; ok {
|
|
return fmt.Errorf("%w: duplicate key %q in map", ErrStore, k)
|
|
}
|
|
var v any
|
|
if fm.Nonzero(i) {
|
|
v = ft.MapValue.parseValue(p)
|
|
} else {
|
|
v = ft.MapValue.zeroExportValue()
|
|
}
|
|
m[k] = v
|
|
}
|
|
return m
|
|
case kindStruct:
|
|
fm := p.Fieldmap(len(ft.structFields))
|
|
m := map[string]any{}
|
|
for i, f := range ft.structFields {
|
|
if fm.Nonzero(i) {
|
|
m[f.Name] = f.Type.parseValue(p)
|
|
} else {
|
|
m[f.Name] = f.Type.zeroExportValue()
|
|
}
|
|
}
|
|
return m
|
|
}
|
|
p.Errorf("internal error: unhandled field type %v", ft.Kind)
|
|
panic("cannot happen")
|
|
}
|
|
|
|
var zeroExportValues = map[kind]any{
|
|
kindBytes: []byte(nil),
|
|
kindBinaryMarshal: []byte(nil), // We don't have the actual type available, so we just return binary data.
|
|
kindBool: false,
|
|
kindInt8: int8(0),
|
|
kindInt16: int16(0),
|
|
kindInt32: int32(0),
|
|
kindInt: int(0),
|
|
kindInt64: int64(0),
|
|
kindUint8: uint8(0),
|
|
kindUint16: uint16(0),
|
|
kindUint32: uint32(0),
|
|
kindUint: uint(0),
|
|
kindUint64: uint64(0),
|
|
kindFloat32: float32(0),
|
|
kindFloat64: float64(0),
|
|
kindString: "",
|
|
kindTime: zerotime,
|
|
kindSlice: []any(nil),
|
|
kindMap: map[string]any(nil),
|
|
kindStruct: map[string]any(nil),
|
|
// kindArray handled in zeroExportValue()
|
|
}
|
|
|
|
// zeroExportValue returns the zero value for a fieldType for use with exporting.
|
|
func (ft fieldType) zeroExportValue() any {
|
|
if ft.Kind == kindArray {
|
|
ev := ft.ListElem.zeroExportValue()
|
|
l := make([]any, ft.ArrayLength)
|
|
for i := 0; i < ft.ArrayLength; i++ {
|
|
l[i] = ev
|
|
}
|
|
return l
|
|
}
|
|
v, ok := zeroExportValues[ft.Kind]
|
|
if !ok {
|
|
panic(fmt.Errorf("internal error: unhandled zero value for field type %v", ft.Kind))
|
|
}
|
|
return v
|
|
}
|
|
|
|
var zeroKeys = map[kind]any{
|
|
kindBytes: []byte(nil),
|
|
kindBool: false,
|
|
kindInt8: int8(0),
|
|
kindInt16: int16(0),
|
|
kindInt32: int32(0),
|
|
kindInt: int(0),
|
|
kindInt64: int64(0),
|
|
kindUint8: uint8(0),
|
|
kindUint16: uint16(0),
|
|
kindUint32: uint32(0),
|
|
kindUint: uint(0),
|
|
kindUint64: uint64(0),
|
|
kindString: "",
|
|
kindTime: zerotime,
|
|
// kindSlice handled in zeroKeyValue()
|
|
}
|
|
|
|
// zeroKeyValue returns the zero value for a fieldType for use with exporting.
|
|
func (ft fieldType) zeroKey() any {
|
|
k := ft.Kind
|
|
if k == kindSlice {
|
|
k = ft.ListElem.Kind
|
|
}
|
|
v, ok := zeroKeys[k]
|
|
if !ok {
|
|
panic(fmt.Errorf("internal error: unhandled zero value for field type %v", ft.Kind))
|
|
}
|
|
return v
|
|
}
|