mirror of
https://github.com/mjl-/mox.git
synced 2024-12-26 16:33:47 +03:00
d1e93020d8
the underscores aren't valid, but have been seen in the wild, so we have a workaround for them. there are limitations, it won't work with idna domains. and if the domain has other policies, like mta-sts, the mx host won't pass either. after report from richard g about delivery issue, thanks!
38 lines
1.3 KiB
Go
38 lines
1.3 KiB
Go
package dns
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseDomain(t *testing.T) {
|
|
test := func(lax bool, s string, exp Domain, expErr error) {
|
|
t.Helper()
|
|
var dom Domain
|
|
var err error
|
|
if lax {
|
|
dom, err = ParseDomainLax(s)
|
|
} else {
|
|
dom, err = ParseDomain(s)
|
|
}
|
|
if (err == nil) != (expErr == nil) || expErr != nil && !errors.Is(err, expErr) {
|
|
t.Fatalf("parse domain %q: err %v, expected %v", s, err, expErr)
|
|
}
|
|
if expErr == nil && dom != exp {
|
|
t.Fatalf("parse domain %q: got %#v, epxected %#v", s, dom, exp)
|
|
}
|
|
}
|
|
|
|
// We rely on normalization of names throughout the code base.
|
|
test(false, "xmox.nl", Domain{"xmox.nl", ""}, nil)
|
|
test(false, "XMOX.NL", Domain{"xmox.nl", ""}, nil)
|
|
test(false, "TEST☺.XMOX.NL", Domain{"xn--test-3o3b.xmox.nl", "test☺.xmox.nl"}, nil)
|
|
test(false, "TEST☺.XMOX.NL", Domain{"xn--test-3o3b.xmox.nl", "test☺.xmox.nl"}, nil)
|
|
test(false, "ℂᵤⓇℒ。𝐒🄴", Domain{"curl.se", ""}, nil) // https://daniel.haxx.se/blog/2022/12/14/idn-is-crazy/
|
|
test(false, "xmox.nl.", Domain{}, errTrailingDot)
|
|
|
|
test(false, "_underscore.xmox.nl", Domain{}, errIDNA)
|
|
test(true, "_underscore.xmox.NL", Domain{ASCII: "_underscore.xmox.nl"}, nil)
|
|
test(true, "_underscore.☺.xmox.nl", Domain{}, errUnderscore)
|
|
test(true, "_underscore.xn--test-3o3b.xmox.nl", Domain{}, errUnderscore)
|
|
}
|