mirror of
https://github.com/mjl-/mox.git
synced 2025-04-21 13:39:45 +03:00
e7b562e3f2
The imapclient needs more changes, like more strict parsing, before it can be a generally usable IMAP client, these are a few steps towards that. - Fix a bug in the imapserver METADATA responses for TOOMANY and MAXSIZE. - Split low-level IMAP protocol handling (new Proto type) from the higher-level client command handling (existing Conn type). The idea is that some simple uses of IMAP can get by with just using these commands, while more intricate uses of IMAP (like a synchronizing client that needs to talk to all kinds of servers with different behaviours and implemented extensions) can write custom commands and read untagged responses or command completion results explicitly. The lower-level method names have clearer names now, like ReadResponse instead of Response. - Merge the untagged responses and (command completion) "Result" into a new type Response. Makes function signatures simpler. And make Response implement the error interface, and change command methods to return the Response as error if the result is NO or BAD. Simplifies error handling, and still provides the option to continue after a NO or BAD. - Add UIDSearch/MSNSearch commands, with a custom "search program", so mostly to indicate these commands exist. - More complete coverage of types for response codes, for easier handling. - Automatically handle any ENABLED or CAPABILITY untagged response or response code for IMAP command methods on type Conn. - Make difference between MSN vs UID versions of FETCH/STORE/SEARCH/COPY/MOVE/REPLACE commands more clear. The original MSN commands now have MSN prefixed to their name, so they are grouped together in the documentation. - Document which capabilities are needed for a command.
82 lines
2.5 KiB
Go
82 lines
2.5 KiB
Go
package imapserver
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"encoding/base64"
|
|
"io"
|
|
mathrand "math/rand/v2"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestCompress(t *testing.T) {
|
|
tc := start(t, false)
|
|
defer tc.close()
|
|
|
|
tc.login("mjl@mox.example", password0)
|
|
|
|
tc.transactf("bad", "compress")
|
|
tc.transactf("bad", "compress bogus ")
|
|
tc.transactf("no", "compress bogus")
|
|
|
|
tc.client.CompressDeflate()
|
|
tc.transactf("no", "compress deflate") // Cannot have multiple.
|
|
tc.xcodeWord("COMPRESSIONACTIVE")
|
|
|
|
tc.client.Select("inbox")
|
|
tc.transactf("ok", "append inbox (\\seen) {%d+}\r\n%s", len(exampleMsg), exampleMsg)
|
|
tc.transactf("ok", "noop")
|
|
tc.transactf("ok", "fetch 1 body.peek[1]")
|
|
}
|
|
|
|
func TestCompressStartTLS(t *testing.T) {
|
|
tc := start(t, false)
|
|
defer tc.close()
|
|
|
|
tc.client.StartTLS(&tls.Config{InsecureSkipVerify: true})
|
|
tc.login("mjl@mox.example", password0)
|
|
tc.client.CompressDeflate()
|
|
tc.client.Select("inbox")
|
|
tc.transactf("ok", "append inbox (\\seen) {%d+}\r\n%s", len(exampleMsg), exampleMsg)
|
|
tc.transactf("ok", "noop")
|
|
tc.transactf("ok", "fetch 1 body.peek[1]")
|
|
}
|
|
|
|
func TestCompressBreak(t *testing.T) {
|
|
// Close the client connection when the server is writing. That causes writes in
|
|
// the server to fail (panic), jumping out of the flate writer and leaving its
|
|
// state inconsistent. We must not call into the flate writer again because due to
|
|
// its broken internal state it may cause array out of bounds accesses.
|
|
|
|
tc := start(t, false)
|
|
defer tc.close()
|
|
|
|
msg := exampleMsg
|
|
// Add random data (so it is not compressible). Don't know why, but only
|
|
// reproducible with large writes. As if setting socket buffers had no effect.
|
|
buf := make([]byte, 64*1024)
|
|
_, err := io.ReadFull(mathrand.NewChaCha8([32]byte{}), buf)
|
|
tcheck(t, err, "read random")
|
|
text := base64.StdEncoding.EncodeToString(buf)
|
|
for len(text) > 0 {
|
|
n := min(76, len(text))
|
|
msg += text[:n] + "\r\n"
|
|
text = text[n:]
|
|
}
|
|
|
|
tc.login("mjl@mox.example", password0)
|
|
tc.client.CompressDeflate()
|
|
tc.client.Select("inbox")
|
|
tc.transactf("ok", "append inbox (\\seen) {%d+}\r\n%s", len(msg), msg)
|
|
tc.transactf("ok", "noop")
|
|
|
|
// Write request. Close connection instead of reading data. Write will panic,
|
|
// coming through flate writer leaving its state inconsistent. Server must not try
|
|
// to Flush/Write again on flate writer or it may panic.
|
|
tc.client.Writelinef("x fetch 1 body.peek[1]")
|
|
|
|
// Close client connection and prevent cleanup from closing the client again.
|
|
time.Sleep(time.Second / 10)
|
|
tc.client = nil
|
|
tc.conn.Close() // Simulate client disappearing.
|
|
}
|