mirror of
https://github.com/mjl-/mox.git
synced 2024-12-25 16:03:48 +03:00
7f5e1087d4
if admin has disabled mta-sts for a domain, we still check for records & policies, but won't mark it as error when they don't exist. we do now keep warning that mta-sts isn't enabled, otherwise we would start showing a green "ok". this also fixes the mta-sts code returning ErrNoPolicy when mtasts.<domain> doesn't exist. the dns lookup is done with the reguler "net" package dns lookup code, not through adns, so we look for two types of DNSError's. noticed a while ago when testing with MTA-STS while debugging TLS connection issues with MS.
167 lines
5.4 KiB
Go
167 lines
5.4 KiB
Go
// Package dns helps parse internationalized domain names (IDNA), canonicalize
|
|
// names and provides a strict and metrics-keeping logging DNS resolver.
|
|
package dns
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net"
|
|
"strings"
|
|
|
|
"golang.org/x/net/idna"
|
|
|
|
"github.com/mjl-/adns"
|
|
)
|
|
|
|
// Pedantic enables stricter parsing.
|
|
var Pedantic bool
|
|
|
|
var (
|
|
errTrailingDot = errors.New("dns name has trailing dot")
|
|
errUnderscore = errors.New("domain name with underscore")
|
|
errIDNA = errors.New("idna")
|
|
)
|
|
|
|
// Domain is a domain name, with one or more labels, with at least an ASCII
|
|
// representation, and for IDNA non-ASCII domains a unicode representation.
|
|
// The ASCII string must be used for DNS lookups. The strings do not have a
|
|
// trailing dot. When using with StrictResolver, add the trailing dot.
|
|
type Domain struct {
|
|
// A non-unicode domain, e.g. with A-labels (xn--...) or NR-LDH (non-reserved
|
|
// letters/digits/hyphens) labels. Always in lower case. No trailing dot.
|
|
ASCII string
|
|
|
|
// Name as U-labels, in Unicode NFC. Empty if this is an ASCII-only domain. No
|
|
// trailing dot.
|
|
Unicode string
|
|
}
|
|
|
|
// Name returns the unicode name if set, otherwise the ASCII name.
|
|
func (d Domain) Name() string {
|
|
if d.Unicode != "" {
|
|
return d.Unicode
|
|
}
|
|
return d.ASCII
|
|
}
|
|
|
|
// XName is like Name, but only returns a unicode name when utf8 is true.
|
|
func (d Domain) XName(utf8 bool) string {
|
|
if utf8 && d.Unicode != "" {
|
|
return d.Unicode
|
|
}
|
|
return d.ASCII
|
|
}
|
|
|
|
// ASCIIExtra returns the ASCII version of the domain name if smtputf8 is true and
|
|
// this is a unicode domain name. Otherwise it returns an empty string.
|
|
//
|
|
// This function is used to add the punycode name in a comment to SMTP message
|
|
// headers, e.g. Received and Authentication-Results.
|
|
func (d Domain) ASCIIExtra(smtputf8 bool) string {
|
|
if smtputf8 && d.Unicode != "" {
|
|
return d.ASCII
|
|
}
|
|
return ""
|
|
}
|
|
|
|
// Strings returns a human-readable string.
|
|
// For IDNA names, the string contains both the unicode and ASCII name.
|
|
func (d Domain) String() string {
|
|
return d.LogString()
|
|
}
|
|
|
|
// LogString returns a domain for logging.
|
|
// For IDNA names, the string is the slash-separated Unicode and ASCII name.
|
|
// For ASCII-only domain names, just the ASCII string is returned.
|
|
func (d Domain) LogString() string {
|
|
if d.Unicode == "" {
|
|
return d.ASCII
|
|
}
|
|
return d.Unicode + "/" + d.ASCII
|
|
}
|
|
|
|
// IsZero returns if this is an empty Domain.
|
|
func (d Domain) IsZero() bool {
|
|
return d == Domain{}
|
|
}
|
|
|
|
// ParseDomain parses a domain name that can consist of ASCII-only labels or U
|
|
// labels (unicode).
|
|
// Names are IDN-canonicalized and lower-cased.
|
|
// Characters in unicode can be replaced by equivalents. E.g. "Ⓡ" to "r". This
|
|
// means you should only compare parsed domain names, never unparsed strings
|
|
// directly.
|
|
func ParseDomain(s string) (Domain, error) {
|
|
if strings.HasSuffix(s, ".") {
|
|
return Domain{}, errTrailingDot
|
|
}
|
|
|
|
ascii, err := idna.Lookup.ToASCII(s)
|
|
if err != nil {
|
|
return Domain{}, fmt.Errorf("%w: to ascii: %v", errIDNA, err)
|
|
}
|
|
unicode, err := idna.Lookup.ToUnicode(s)
|
|
if err != nil {
|
|
return Domain{}, fmt.Errorf("%w: to unicode: %w", errIDNA, err)
|
|
}
|
|
// todo: should we cause errors for unicode domains that were not in
|
|
// canonical form? we are now accepting all kinds of obscure spellings
|
|
// for even a basic ASCII domain name.
|
|
// Also see https://daniel.haxx.se/blog/2022/12/14/idn-is-crazy/
|
|
if ascii == unicode {
|
|
return Domain{ascii, ""}, nil
|
|
}
|
|
return Domain{ascii, unicode}, nil
|
|
}
|
|
|
|
// ParseDomainLax parses a domain like ParseDomain, but allows labels with
|
|
// underscores if the entire domain name is ASCII-only non-IDNA and Pedantic mode
|
|
// is not enabled. Used for interoperability, e.g. domains may specify MX
|
|
// targets with underscores.
|
|
func ParseDomainLax(s string) (Domain, error) {
|
|
if Pedantic || !strings.Contains(s, "_") {
|
|
return ParseDomain(s)
|
|
}
|
|
|
|
// If there is any non-ASCII, this is certainly not an A-label-only domain.
|
|
s = strings.ToLower(s)
|
|
for _, c := range s {
|
|
if c >= 0x80 {
|
|
return Domain{}, fmt.Errorf("%w: underscore and non-ascii not allowed", errUnderscore)
|
|
}
|
|
}
|
|
|
|
// Try parsing with underscores replaced with allowed ASCII character.
|
|
// If that's not valid, the version with underscore isn't either.
|
|
repl := strings.ReplaceAll(s, "_", "a")
|
|
d, err := ParseDomain(repl)
|
|
if err != nil {
|
|
return Domain{}, fmt.Errorf("%w: %v", errUnderscore, err)
|
|
}
|
|
// If we found an IDNA domain, we're not going to allow it.
|
|
if d.Unicode != "" {
|
|
return Domain{}, fmt.Errorf("%w: idna domain with underscores not allowed", errUnderscore)
|
|
}
|
|
// Just to be safe, ensure no unexpected conversions happened.
|
|
if d.ASCII != repl {
|
|
return Domain{}, fmt.Errorf("%w: underscores and non-canonical names not allowed", errUnderscore)
|
|
}
|
|
return Domain{ASCII: s}, nil
|
|
}
|
|
|
|
// IsNotFound returns whether an error is an adns.DNSError or net.DNSError with
|
|
// IsNotFound set.
|
|
//
|
|
// IsNotFound means the requested type does not exist for the given domain (a
|
|
// nodata or nxdomain response). It doesn't not necessarily mean no other types for
|
|
// that name exist.
|
|
//
|
|
// A DNS server can respond to a lookup with an error "nxdomain" to indicate a
|
|
// name does not exist (at all), or with a success status with an empty list.
|
|
// The adns resolver (just like the Go resolver) returns an IsNotFound error for
|
|
// both cases, there is no need to explicitly check for zero entries.
|
|
func IsNotFound(err error) bool {
|
|
var adnsErr *adns.DNSError
|
|
var dnsErr *net.DNSError
|
|
return err != nil && (errors.As(err, &adnsErr) && adnsErr.IsNotFound || errors.As(err, &dnsErr) && dnsErr.IsNotFound)
|
|
}
|