serv/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2024-12-26 08:23:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

if webauth login cookie is missing, and forwarding was configured, hint that reverse proxy may be stripping path

Browse source 
the cookies are set with a specific path, because the webadmin, webaccount and
webmail cookies can be on the same domain (this is the default). if the reverse
proxy strips the path while forwarding, the browser won't set the cookie and
the login attempt will fail.

based on github issue #151 from naturalethic
This commit is contained in:
Mechiel Lukkien 2024-04-16 16:06:31 +02:00
parent daa88480cb
commit afc47c8108
No known key found for this signature in database
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
webauth/webauth.go
View file

@ -227,7 +227,11 @@ func LoginPrep(ctx context.Context, log mlog.Log, kind, cookiePath string, isFor
func Login(ctx context.Context, log mlog.Log, sessionAuth SessionAuth, kind, cookiePath string, isForwarded bool, w http.ResponseWriter, r *http.Request, loginToken, username, password string) (store.CSRFToken, error) {
loginCookie, _ := r.Cookie(kind + "login")
if loginCookie == nil || loginCookie.Value != loginToken {
return "", &sherpa.Error{Code: "user:error", Message: "missing login token"}
msg := "missing login token cookie"
if isForwarded && loginCookie == nil {
msg += " (hint: reverse proxy must keep path, for login cookie)"
}
return "", &sherpa.Error{Code: "user:error", Message: msg}
}
ip := RemoteIP(log, isForwarded, r)