serv/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2024-12-27 08:53:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

add todo's about mime header parameter decoding

Browse source 
not sure what the correct approach is, would need to analyze email archive for practices.
This commit is contained in:
Mechiel Lukkien 2023-09-21 14:51:47 +02:00
parent f87f286b80
commit 79774c15ec
No known key found for this signature in database
4 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
webmail/api.go
View file

@ -135,6 +135,7 @@ type Attachment struct {
// File name based on "name" attribute of "Content-Type", or the "filename"
// attribute of "Content-Disposition".
// todo: decode non-ascii character sets
Filename string
Part message.Part

2
webmail/api.json
View file

@ -1954,7 +1954,7 @@
},
{
"Name": "Filename",
"Docs": "File name based on \"name\" attribute of \"Content-Type\", or the \"filename\" attribute of \"Content-Disposition\".",
"Docs": "File name based on \"name\" attribute of \"Content-Type\", or the \"filename\" attribute of \"Content-Disposition\". todo: decode non-ascii character sets",
"Typewords": [
"string"
]

2
webmail/api.ts
View file

@ -322,7 +322,7 @@ export interface MessageEnvelope {
// viewable text or HTML part.
export interface Attachment {
Path?: number[] | null // Indices into top-level message.Part.Parts.
Filename: string // File name based on "name" attribute of "Content-Type", or the "filename" attribute of "Content-Disposition".
Filename: string // File name based on "name" attribute of "Content-Type", or the "filename" attribute of "Content-Disposition". todo: decode non-ascii character sets
Part: Part
}

1
webmail/message.go
View file

@ -212,6 +212,7 @@ func parsedMessage(log *mlog.Log, m store.Message, state *msgState, full, msgite
disp, params, err := mime.ParseMediaType(cp)
log.Check(err, "parsing content-disposition", mlog.Field("cp", cp))
if strings.EqualFold(disp, "attachment") {
// todo: should we be decoding these names? i've seen messages with regular q-word style mime-encoding, not the one specified in ../rfc/2231:210
name := p.ContentTypeParams["name"]
if name == "" {
name = params["filename"]