serv/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2024-12-27 08:53:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

in quickstart, if the host name resolves to a loopback IP, warn about it as it will likely prevent email delivery to local accounts

Browse source 
would have helped for issue #37, thanks @dmikushin for reporting
This commit is contained in:
Mechiel Lukkien 2023-06-12 12:19:20 +02:00
parent 0187fa0394
commit 64ac9872a4
No known key found for this signature in database
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
quickstart.go
View file

@ -305,7 +305,6 @@ again with the -hostname flag.
} }
} }
// todo: lookup without going through /etc/hosts, because a machine typically has its name configured there, and LookupIPAddr will return it, but we care about DNS settings that the rest of the world uses to find us. perhaps we should check if the address resolves to 127.0.0.0/8?
fmt.Printf("Looking up IPs for hostname %s...", dnshostname) fmt.Printf("Looking up IPs for hostname %s...", dnshostname)
ipctx, ipcancel := context.WithTimeout(resolveCtx, 5*time.Second) ipctx, ipcancel := context.WithTimeout(resolveCtx, 5*time.Second)
defer ipcancel() defer ipcancel()
@ -313,17 +312,22 @@ again with the -hostname flag.
ipcancel() ipcancel()
var xips []net.IPAddr var xips []net.IPAddr
var xipstrs []string var xipstrs []string
var dnswarned bool
for _, ip := range ips { for _, ip := range ips {
// During linux install, you may get an alias for you full hostname in /etc/hosts // During linux install, you may get an alias for you full hostname in /etc/hosts
// resolving to 127.0.1.1, which would result in a false positive about the // resolving to 127.0.1.1, which would result in a false positive about the
// hostname having a record. Filter it out. It is a bit surprising that hosts don't // hostname having a record. Filter it out. It is a bit surprising that hosts don't
// otherwise know their FQDN. // otherwise know their FQDN.
if !ip.IP.IsLoopback() { if ip.IP.IsLoopback() {
dnswarned = true
fmt.Printf("\n\nWARNING: Your hostname is resolving to a loopback IP address %s. This likely breaks email delivery to local accounts. /etc/hosts likely contains a line like %q. Either replace it with your actual IP(s), or remove the line.\n", ip.IP, fmt.Sprintf("%s %s", ip.IP, dnshostname.ASCII))
continue
}
xips = append(xips, ip) xips = append(xips, ip)
xipstrs = append(xipstrs, ip.String()) xipstrs = append(xipstrs, ip.String())
} }
}
if err == nil && len(xips) == 0 { if err == nil && len(xips) == 0 {
// todo: possibly check this by trying to resolve without using /etc/hosts?
err = errors.New("hostname not in dns, probably only in /etc/hosts") err = errors.New("hostname not in dns, probably only in /etc/hosts")
} }
ips = xips ips = xips
@ -333,8 +337,11 @@ again with the -hostname flag.
publicIPs = xipstrs publicIPs = xipstrs
} }
if err != nil { if err != nil {
if !dnswarned {
fmt.Printf("\n")
}
dnswarned = true
fmt.Printf(` fmt.Printf(`
WARNING: Quickstart assumed the hostname of this machine is %s and generates a WARNING: Quickstart assumed the hostname of this machine is %s and generates a
config for that host, but could not retrieve that name from DNS: config for that host, but could not retrieve that name from DNS:
@ -351,7 +358,9 @@ This likely means one of two things:
`, dnshostname, err) `, dnshostname, err)
} else { }
if !dnswarned {
fmt.Printf(" OK\n") fmt.Printf(" OK\n")
var l []string var l []string