From 46aacdb79bd490a5f9588b1a31c5df93eade5088 Mon Sep 17 00:00:00 2001 From: Mechiel Lukkien Date: Fri, 12 Jan 2024 15:25:23 +0100 Subject: [PATCH] webmail: when q/b-word-decoding attachment filenames, recognize more charset encodings based on #113 by jsfan3 --- webmail/message.go | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/webmail/message.go b/webmail/message.go index 0a5aa01..79e195f 100644 --- a/webmail/message.go +++ b/webmail/message.go @@ -9,6 +9,7 @@ import ( "strings" "golang.org/x/exp/slog" + "golang.org/x/text/encoding/ianaindex" "github.com/mjl-/mox/dns" "github.com/mjl-/mox/message" @@ -21,6 +22,23 @@ import ( // todo: we should have all needed information for messageItem in store.Message (perhaps some data in message.Part) for fast access, not having to parse the on-disk message file. +var wordDecoder = mime.WordDecoder{ + CharsetReader: func(charset string, r io.Reader) (io.Reader, error) { + switch strings.ToLower(charset) { + case "", "us-ascii", "utf-8": + return r, nil + } + enc, _ := ianaindex.MIME.Encoding(charset) + if enc == nil { + enc, _ = ianaindex.IANA.Encoding(charset) + } + if enc == nil { + return r, fmt.Errorf("unknown charset %q", charset) + } + return enc.NewDecoder().Reader(r), nil + }, +} + // Attempt q/b-word-decode name, coming from Content-Type "name" field or // Content-Disposition "filename" field. // @@ -43,8 +61,7 @@ func tryDecodeParam(log mlog.Log, name string) string { log.Debug("attachment contains rfc2047 q/b-word-encoded mime parameter instead of rfc2231-encoded", slog.String("name", name)) return name } - dec := mime.WordDecoder{} - s, err := dec.DecodeHeader(name) + s, err := wordDecoder.DecodeHeader(name) if err != nil { log.Debugx("q/b-word decoding mime parameter", err, slog.String("name", name)) return name