2023-01-30 16:27:06 +03:00
|
|
|
package imapserver
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
make mox compile on windows, without "mox serve" but with working "mox localserve"
getting mox to compile required changing code in only a few places where
package "syscall" was used: for accessing file access times and for umask
handling. an open problem is how to start a process as an unprivileged user on
windows. that's why "mox serve" isn't implemented yet. and just finding a way
to implement it now may not be good enough in the near future: we may want to
starting using a more complete privilege separation approach, with a process
handling sensitive tasks (handling private keys, authentication), where we may
want to pass file descriptors between processes. how would that work on
windows?
anyway, getting mox to compile for windows doesn't mean it works properly on
windows. the largest issue: mox would normally open a file, rename or remove
it, and finally close it. this happens during message delivery. that doesn't
work on windows, the rename/remove would fail because the file is still open.
so this commit swaps many "remove" and "close" calls. renames are a longer
story: message delivery had two ways to deliver: with "consuming" the
(temporary) message file (which would rename it to its final destination), and
without consuming (by hardlinking the file, falling back to copying). the last
delivery to a recipient of a message (and the only one in the common case of a
single recipient) would consume the message, and the earlier recipients would
not. during delivery, the already open message file was used, to parse the
message. we still want to use that open message file, and the caller now stays
responsible for closing it, but we no longer try to rename (consume) the file.
we always hardlink (or copy) during delivery (this works on windows), and the
caller is responsible for closing and removing (in that order) the original
temporary file. this does cost one syscall more. but it makes the delivery code
(responsibilities) a bit simpler.
there is one more obvious issue: the file system path separator. mox already
used the "filepath" package to join paths in many places, but not everywhere.
and it still used strings with slashes for local file access. with this commit,
the code now uses filepath.FromSlash for path strings with slashes, uses
"filepath" in a few more places where it previously didn't. also switches from
"filepath" to regular "path" package when handling mailbox names in a few
places, because those always use forward slashes, regardless of local file
system conventions. windows can handle forward slashes when opening files, so
test code that passes path strings with forward slashes straight to go stdlib
file i/o functions are left unchanged to reduce code churn. the regular
non-test code, or test code that uses path strings in places other than
standard i/o functions, does have the paths converted for consistent paths
(otherwise we would end up with paths with mixed forward/backward slashes in
log messages).
windows cannot dup a listening socket. for "mox localserve", it isn't
important, and we can work around the issue. the current approach for "mox
serve" (forking a process and passing file descriptors of listening sockets on
"privileged" ports) won't work on windows. perhaps it isn't needed on windows,
and any user can listen on "privileged" ports? that would be welcome.
on windows, os.Open cannot open a directory, so we cannot call Sync on it after
message delivery. a cursory internet search indicates that directories cannot
be synced on windows. the story is probably much more nuanced than that, with
long deep technical details/discussions/disagreement/confusion, like on unix.
for "mox localserve" we can get away with making syncdir a no-op.
2023-10-14 11:54:07 +03:00
|
|
|
"path"
|
2023-01-30 16:27:06 +03:00
|
|
|
"sort"
|
|
|
|
"strings"
|
|
|
|
|
|
|
|
"github.com/mjl-/bstore"
|
|
|
|
"github.com/mjl-/mox/store"
|
|
|
|
)
|
|
|
|
|
|
|
|
// LIST command, for listing mailboxes with various attributes, including about subscriptions and children.
|
|
|
|
// We don't have flags Marked, Unmarked, NoSelect and NoInferiors and we don't have REMOTE mailboxes.
|
|
|
|
//
|
|
|
|
// State: Authenticated and selected.
|
|
|
|
func (c *conn) cmdList(tag, cmd string, p *parser) {
|
|
|
|
// Command: ../rfc/9051:2224 ../rfc/6154:144 ../rfc/5258:193 ../rfc/3501:2191
|
|
|
|
// Examples: ../rfc/9051:2755 ../rfc/6154:347 ../rfc/5258:679 ../rfc/3501:2359
|
|
|
|
|
|
|
|
// Request syntax: ../rfc/9051:6600 ../rfc/6154:478 ../rfc/5258:1095 ../rfc/3501:4793
|
|
|
|
p.xspace()
|
|
|
|
var isExtended bool
|
|
|
|
var listSubscribed bool
|
|
|
|
var listRecursive bool
|
|
|
|
if p.take("(") {
|
|
|
|
// ../rfc/9051:6633
|
|
|
|
isExtended = true
|
|
|
|
selectOptions := map[string]bool{}
|
|
|
|
var nbase int
|
|
|
|
for !p.take(")") {
|
|
|
|
if len(selectOptions) > 0 {
|
|
|
|
p.xspace()
|
|
|
|
}
|
|
|
|
w := p.xatom()
|
|
|
|
W := strings.ToUpper(w)
|
|
|
|
switch W {
|
|
|
|
case "REMOTE":
|
|
|
|
case "RECURSIVEMATCH":
|
|
|
|
listRecursive = true
|
|
|
|
case "SUBSCRIBED":
|
|
|
|
nbase++
|
|
|
|
listSubscribed = true
|
|
|
|
default:
|
|
|
|
// ../rfc/9051:2398
|
|
|
|
xsyntaxErrorf("bad list selection option %q", w)
|
|
|
|
}
|
|
|
|
// Duplicates must be accepted. ../rfc/9051:2399
|
|
|
|
selectOptions[W] = true
|
|
|
|
}
|
|
|
|
if listRecursive && nbase == 0 {
|
|
|
|
// ../rfc/9051:6640
|
|
|
|
xsyntaxErrorf("cannot have RECURSIVEMATCH selection option without other (base) selection option")
|
|
|
|
}
|
|
|
|
p.xspace()
|
|
|
|
}
|
|
|
|
reference := p.xmailbox()
|
|
|
|
p.xspace()
|
|
|
|
patterns, isList := p.xmboxOrPat()
|
|
|
|
isExtended = isExtended || isList
|
2023-09-23 22:00:26 +03:00
|
|
|
var retSubscribed, retChildren bool
|
2023-01-30 16:27:06 +03:00
|
|
|
var retStatusAttrs []string
|
|
|
|
if p.take(" RETURN (") {
|
|
|
|
isExtended = true
|
|
|
|
// ../rfc/9051:6613 ../rfc/9051:6915 ../rfc/9051:7072 ../rfc/9051:6821 ../rfc/5819:95
|
|
|
|
n := 0
|
|
|
|
for !p.take(")") {
|
|
|
|
if n > 0 {
|
|
|
|
p.xspace()
|
|
|
|
}
|
|
|
|
n++
|
|
|
|
w := p.xatom()
|
|
|
|
W := strings.ToUpper(w)
|
|
|
|
switch W {
|
|
|
|
case "SUBSCRIBED":
|
|
|
|
retSubscribed = true
|
|
|
|
case "CHILDREN":
|
|
|
|
// ../rfc/3348:44
|
|
|
|
retChildren = true
|
|
|
|
case "SPECIAL-USE":
|
|
|
|
// ../rfc/6154:478
|
2023-09-23 22:00:26 +03:00
|
|
|
// We always include special-use mailbox flags. Mac OS X Mail 16.0 (sept 2023) does
|
|
|
|
// not ask for the flags, but does use them when given. ../rfc/6154:146
|
2023-01-30 16:27:06 +03:00
|
|
|
case "STATUS":
|
|
|
|
// ../rfc/9051:7072 ../rfc/5819:181
|
|
|
|
p.xspace()
|
|
|
|
p.xtake("(")
|
|
|
|
retStatusAttrs = []string{p.xstatusAtt()}
|
|
|
|
for p.take(" ") {
|
|
|
|
retStatusAttrs = append(retStatusAttrs, p.xstatusAtt())
|
|
|
|
}
|
|
|
|
p.xtake(")")
|
|
|
|
default:
|
|
|
|
// ../rfc/9051:2398
|
|
|
|
xsyntaxErrorf("bad list return option %q", w)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
p.xempty()
|
|
|
|
|
|
|
|
if !isExtended && reference == "" && patterns[0] == "" {
|
|
|
|
// ../rfc/9051:2277 ../rfc/3501:2221
|
|
|
|
c.bwritelinef(`* LIST () "/" ""`)
|
|
|
|
c.ok(tag, cmd)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if isExtended {
|
|
|
|
// ../rfc/9051:2286
|
|
|
|
n := make([]string, 0, len(patterns))
|
|
|
|
for _, p := range patterns {
|
|
|
|
if p != "" {
|
|
|
|
n = append(n, p)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
patterns = n
|
|
|
|
}
|
|
|
|
re := xmailboxPatternMatcher(reference, patterns)
|
|
|
|
var responseLines []string
|
|
|
|
|
|
|
|
c.account.WithRLock(func() {
|
|
|
|
c.xdbread(func(tx *bstore.Tx) {
|
|
|
|
type info struct {
|
|
|
|
mailbox *store.Mailbox
|
|
|
|
subscribed bool
|
|
|
|
}
|
|
|
|
names := map[string]info{}
|
|
|
|
hasSubscribedChild := map[string]bool{}
|
|
|
|
hasChild := map[string]bool{}
|
|
|
|
var nameList []string
|
|
|
|
|
|
|
|
q := bstore.QueryTx[store.Mailbox](tx)
|
|
|
|
err := q.ForEach(func(mb store.Mailbox) error {
|
|
|
|
names[mb.Name] = info{mailbox: &mb}
|
|
|
|
nameList = append(nameList, mb.Name)
|
make mox compile on windows, without "mox serve" but with working "mox localserve"
getting mox to compile required changing code in only a few places where
package "syscall" was used: for accessing file access times and for umask
handling. an open problem is how to start a process as an unprivileged user on
windows. that's why "mox serve" isn't implemented yet. and just finding a way
to implement it now may not be good enough in the near future: we may want to
starting using a more complete privilege separation approach, with a process
handling sensitive tasks (handling private keys, authentication), where we may
want to pass file descriptors between processes. how would that work on
windows?
anyway, getting mox to compile for windows doesn't mean it works properly on
windows. the largest issue: mox would normally open a file, rename or remove
it, and finally close it. this happens during message delivery. that doesn't
work on windows, the rename/remove would fail because the file is still open.
so this commit swaps many "remove" and "close" calls. renames are a longer
story: message delivery had two ways to deliver: with "consuming" the
(temporary) message file (which would rename it to its final destination), and
without consuming (by hardlinking the file, falling back to copying). the last
delivery to a recipient of a message (and the only one in the common case of a
single recipient) would consume the message, and the earlier recipients would
not. during delivery, the already open message file was used, to parse the
message. we still want to use that open message file, and the caller now stays
responsible for closing it, but we no longer try to rename (consume) the file.
we always hardlink (or copy) during delivery (this works on windows), and the
caller is responsible for closing and removing (in that order) the original
temporary file. this does cost one syscall more. but it makes the delivery code
(responsibilities) a bit simpler.
there is one more obvious issue: the file system path separator. mox already
used the "filepath" package to join paths in many places, but not everywhere.
and it still used strings with slashes for local file access. with this commit,
the code now uses filepath.FromSlash for path strings with slashes, uses
"filepath" in a few more places where it previously didn't. also switches from
"filepath" to regular "path" package when handling mailbox names in a few
places, because those always use forward slashes, regardless of local file
system conventions. windows can handle forward slashes when opening files, so
test code that passes path strings with forward slashes straight to go stdlib
file i/o functions are left unchanged to reduce code churn. the regular
non-test code, or test code that uses path strings in places other than
standard i/o functions, does have the paths converted for consistent paths
(otherwise we would end up with paths with mixed forward/backward slashes in
log messages).
windows cannot dup a listening socket. for "mox localserve", it isn't
important, and we can work around the issue. the current approach for "mox
serve" (forking a process and passing file descriptors of listening sockets on
"privileged" ports) won't work on windows. perhaps it isn't needed on windows,
and any user can listen on "privileged" ports? that would be welcome.
on windows, os.Open cannot open a directory, so we cannot call Sync on it after
message delivery. a cursory internet search indicates that directories cannot
be synced on windows. the story is probably much more nuanced than that, with
long deep technical details/discussions/disagreement/confusion, like on unix.
for "mox localserve" we can get away with making syncdir a no-op.
2023-10-14 11:54:07 +03:00
|
|
|
for p := path.Dir(mb.Name); p != "."; p = path.Dir(p) {
|
2023-01-30 16:27:06 +03:00
|
|
|
hasChild[p] = true
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
xcheckf(err, "listing mailboxes")
|
|
|
|
|
|
|
|
qs := bstore.QueryTx[store.Subscription](tx)
|
|
|
|
err = qs.ForEach(func(sub store.Subscription) error {
|
|
|
|
info, ok := names[sub.Name]
|
|
|
|
info.subscribed = true
|
|
|
|
names[sub.Name] = info
|
|
|
|
if !ok {
|
|
|
|
nameList = append(nameList, sub.Name)
|
|
|
|
}
|
make mox compile on windows, without "mox serve" but with working "mox localserve"
getting mox to compile required changing code in only a few places where
package "syscall" was used: for accessing file access times and for umask
handling. an open problem is how to start a process as an unprivileged user on
windows. that's why "mox serve" isn't implemented yet. and just finding a way
to implement it now may not be good enough in the near future: we may want to
starting using a more complete privilege separation approach, with a process
handling sensitive tasks (handling private keys, authentication), where we may
want to pass file descriptors between processes. how would that work on
windows?
anyway, getting mox to compile for windows doesn't mean it works properly on
windows. the largest issue: mox would normally open a file, rename or remove
it, and finally close it. this happens during message delivery. that doesn't
work on windows, the rename/remove would fail because the file is still open.
so this commit swaps many "remove" and "close" calls. renames are a longer
story: message delivery had two ways to deliver: with "consuming" the
(temporary) message file (which would rename it to its final destination), and
without consuming (by hardlinking the file, falling back to copying). the last
delivery to a recipient of a message (and the only one in the common case of a
single recipient) would consume the message, and the earlier recipients would
not. during delivery, the already open message file was used, to parse the
message. we still want to use that open message file, and the caller now stays
responsible for closing it, but we no longer try to rename (consume) the file.
we always hardlink (or copy) during delivery (this works on windows), and the
caller is responsible for closing and removing (in that order) the original
temporary file. this does cost one syscall more. but it makes the delivery code
(responsibilities) a bit simpler.
there is one more obvious issue: the file system path separator. mox already
used the "filepath" package to join paths in many places, but not everywhere.
and it still used strings with slashes for local file access. with this commit,
the code now uses filepath.FromSlash for path strings with slashes, uses
"filepath" in a few more places where it previously didn't. also switches from
"filepath" to regular "path" package when handling mailbox names in a few
places, because those always use forward slashes, regardless of local file
system conventions. windows can handle forward slashes when opening files, so
test code that passes path strings with forward slashes straight to go stdlib
file i/o functions are left unchanged to reduce code churn. the regular
non-test code, or test code that uses path strings in places other than
standard i/o functions, does have the paths converted for consistent paths
(otherwise we would end up with paths with mixed forward/backward slashes in
log messages).
windows cannot dup a listening socket. for "mox localserve", it isn't
important, and we can work around the issue. the current approach for "mox
serve" (forking a process and passing file descriptors of listening sockets on
"privileged" ports) won't work on windows. perhaps it isn't needed on windows,
and any user can listen on "privileged" ports? that would be welcome.
on windows, os.Open cannot open a directory, so we cannot call Sync on it after
message delivery. a cursory internet search indicates that directories cannot
be synced on windows. the story is probably much more nuanced than that, with
long deep technical details/discussions/disagreement/confusion, like on unix.
for "mox localserve" we can get away with making syncdir a no-op.
2023-10-14 11:54:07 +03:00
|
|
|
for p := path.Dir(sub.Name); p != "."; p = path.Dir(p) {
|
2023-01-30 16:27:06 +03:00
|
|
|
hasSubscribedChild[p] = true
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
xcheckf(err, "listing subscriptions")
|
|
|
|
|
|
|
|
sort.Strings(nameList) // For predictable order in tests.
|
|
|
|
|
|
|
|
for _, name := range nameList {
|
|
|
|
if !re.MatchString(name) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
info := names[name]
|
|
|
|
|
|
|
|
var flags listspace
|
|
|
|
var extended listspace
|
|
|
|
if listRecursive && hasSubscribedChild[name] {
|
|
|
|
extended = listspace{bare("CHILDINFO"), listspace{dquote("SUBSCRIBED")}}
|
|
|
|
}
|
|
|
|
if listSubscribed && info.subscribed {
|
|
|
|
flags = append(flags, bare(`\Subscribed`))
|
|
|
|
if info.mailbox == nil {
|
|
|
|
flags = append(flags, bare(`\NonExistent`))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (info.mailbox == nil || listSubscribed) && flags == nil && extended == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if retChildren {
|
|
|
|
var f string
|
|
|
|
if hasChild[name] {
|
|
|
|
f = `\HasChildren`
|
|
|
|
} else {
|
|
|
|
f = `\HasNoChildren`
|
|
|
|
}
|
|
|
|
flags = append(flags, bare(f))
|
|
|
|
}
|
|
|
|
if !listSubscribed && retSubscribed && info.subscribed {
|
|
|
|
flags = append(flags, bare(`\Subscribed`))
|
|
|
|
}
|
2023-09-23 22:00:26 +03:00
|
|
|
if info.mailbox != nil {
|
2023-01-30 16:27:06 +03:00
|
|
|
if info.mailbox.Archive {
|
|
|
|
flags = append(flags, bare(`\Archive`))
|
|
|
|
}
|
|
|
|
if info.mailbox.Draft {
|
2023-09-23 15:50:02 +03:00
|
|
|
flags = append(flags, bare(`\Drafts`))
|
2023-01-30 16:27:06 +03:00
|
|
|
}
|
|
|
|
if info.mailbox.Junk {
|
|
|
|
flags = append(flags, bare(`\Junk`))
|
|
|
|
}
|
|
|
|
if info.mailbox.Sent {
|
|
|
|
flags = append(flags, bare(`\Sent`))
|
|
|
|
}
|
|
|
|
if info.mailbox.Trash {
|
|
|
|
flags = append(flags, bare(`\Trash`))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
var extStr string
|
|
|
|
if extended != nil {
|
|
|
|
extStr = " " + extended.pack(c)
|
|
|
|
}
|
imapserver: allow creating mailboxes with characters &#*%, and encode mailbox names in imap with imaputf7 when needed
the imapserver started with imap4rev2-only and utf8=only. to prevent potential
issues with imaputf7, which makes "&" special, we refused any mailbox with an
"&" in the name. we already tried decoding utf7, falling back to using a
mailbox name verbatim. that behaviour wasn't great. we now treat the enabled
extensions IMAP4rev2 and/or UTF8=ACCEPT as indication whether mailbox names are
in imaputf7. if they are, the encoding must be correct.
we now also send mailbox names in imaputf7 when imap4rev2/utf8=accept isn't
enabled.
and we now allow "*" and "%" (wildcard characters for matching) in mailbox
names. not ideal for IMAP LIST with patterns, but not enough reason to refuse
them in mailbox names. people that migrate may run into this, possibly as
blocker.
we also allow "#" in mailbox names, but not as first character, to prevent
potential clashes with IMAP namespaces in the future.
based on report from Damian Poddebniak using
https://github.com/duesee/imap-flow and issue #110, thanks for reporting!
2024-01-01 15:15:25 +03:00
|
|
|
line := fmt.Sprintf(`* LIST %s "/" %s%s`, flags.pack(c), astring(c.encodeMailbox(name)).pack(c), extStr)
|
2023-01-30 16:27:06 +03:00
|
|
|
responseLines = append(responseLines, line)
|
|
|
|
|
|
|
|
if retStatusAttrs != nil && info.mailbox != nil {
|
|
|
|
responseLines = append(responseLines, c.xstatusLine(tx, *info.mailbox, retStatusAttrs))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
for _, line := range responseLines {
|
|
|
|
c.bwritelinef("%s", line)
|
|
|
|
}
|
|
|
|
c.ok(tag, cmd)
|
|
|
|
}
|