add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
package webmail
import (
"context"
"fmt"
"net/http"
"os"
make mox compile on windows, without "mox serve" but with working "mox localserve"
getting mox to compile required changing code in only a few places where
package "syscall" was used: for accessing file access times and for umask
handling. an open problem is how to start a process as an unprivileged user on
windows. that's why "mox serve" isn't implemented yet. and just finding a way
to implement it now may not be good enough in the near future: we may want to
starting using a more complete privilege separation approach, with a process
handling sensitive tasks (handling private keys, authentication), where we may
want to pass file descriptors between processes. how would that work on
windows?
anyway, getting mox to compile for windows doesn't mean it works properly on
windows. the largest issue: mox would normally open a file, rename or remove
it, and finally close it. this happens during message delivery. that doesn't
work on windows, the rename/remove would fail because the file is still open.
so this commit swaps many "remove" and "close" calls. renames are a longer
story: message delivery had two ways to deliver: with "consuming" the
(temporary) message file (which would rename it to its final destination), and
without consuming (by hardlinking the file, falling back to copying). the last
delivery to a recipient of a message (and the only one in the common case of a
single recipient) would consume the message, and the earlier recipients would
not. during delivery, the already open message file was used, to parse the
message. we still want to use that open message file, and the caller now stays
responsible for closing it, but we no longer try to rename (consume) the file.
we always hardlink (or copy) during delivery (this works on windows), and the
caller is responsible for closing and removing (in that order) the original
temporary file. this does cost one syscall more. but it makes the delivery code
(responsibilities) a bit simpler.
there is one more obvious issue: the file system path separator. mox already
used the "filepath" package to join paths in many places, but not everywhere.
and it still used strings with slashes for local file access. with this commit,
the code now uses filepath.FromSlash for path strings with slashes, uses
"filepath" in a few more places where it previously didn't. also switches from
"filepath" to regular "path" package when handling mailbox names in a few
places, because those always use forward slashes, regardless of local file
system conventions. windows can handle forward slashes when opening files, so
test code that passes path strings with forward slashes straight to go stdlib
file i/o functions are left unchanged to reduce code churn. the regular
non-test code, or test code that uses path strings in places other than
standard i/o functions, does have the paths converted for consistent paths
(otherwise we would end up with paths with mixed forward/backward slashes in
log messages).
windows cannot dup a listening socket. for "mox localserve", it isn't
important, and we can work around the issue. the current approach for "mox
serve" (forking a process and passing file descriptors of listening sockets on
"privileged" ports) won't work on windows. perhaps it isn't needed on windows,
and any user can listen on "privileged" ports? that would be welcome.
on windows, os.Open cannot open a directory, so we cannot call Sync on it after
message delivery. a cursory internet search indicates that directories cannot
be synced on windows. the story is probably much more nuanced than that, with
long deep technical details/discussions/disagreement/confusion, like on unix.
for "mox localserve" we can get away with making syncdir a no-op.
2023-10-14 11:54:07 +03:00
"path/filepath"
add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
"runtime/debug"
"testing"
"github.com/mjl-/bstore"
"github.com/mjl-/sherpa"
2023-10-15 16:05:20 +03:00
"github.com/mjl-/mox/dns"
add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
"github.com/mjl-/mox/mox-"
"github.com/mjl-/mox/queue"
"github.com/mjl-/mox/store"
)
func tneedError ( t * testing . T , fn func ( ) ) {
t . Helper ( )
defer func ( ) {
t . Helper ( )
x := recover ( )
if x == nil {
debug . PrintStack ( )
t . Fatalf ( "expected sherpa user error, saw success" )
}
if err , ok := x . ( * sherpa . Error ) ; ! ok {
debug . PrintStack ( )
t . Fatalf ( "expected sherpa user error, saw %#v" , x )
} else if err . Code != "user:error" {
debug . PrintStack ( )
t . Fatalf ( "expected sherpa user error, saw other sherpa error %#v" , err )
}
} ( )
fn ( )
}
// Test API calls.
// todo: test that the actions make the changes they claim to make. we currently just call the functions and have only limited checks that state changed.
func TestAPI ( t * testing . T ) {
mox . LimitersInit ( )
os . RemoveAll ( "../testdata/webmail/data" )
mox . Context = ctxbg
make mox compile on windows, without "mox serve" but with working "mox localserve"
getting mox to compile required changing code in only a few places where
package "syscall" was used: for accessing file access times and for umask
handling. an open problem is how to start a process as an unprivileged user on
windows. that's why "mox serve" isn't implemented yet. and just finding a way
to implement it now may not be good enough in the near future: we may want to
starting using a more complete privilege separation approach, with a process
handling sensitive tasks (handling private keys, authentication), where we may
want to pass file descriptors between processes. how would that work on
windows?
anyway, getting mox to compile for windows doesn't mean it works properly on
windows. the largest issue: mox would normally open a file, rename or remove
it, and finally close it. this happens during message delivery. that doesn't
work on windows, the rename/remove would fail because the file is still open.
so this commit swaps many "remove" and "close" calls. renames are a longer
story: message delivery had two ways to deliver: with "consuming" the
(temporary) message file (which would rename it to its final destination), and
without consuming (by hardlinking the file, falling back to copying). the last
delivery to a recipient of a message (and the only one in the common case of a
single recipient) would consume the message, and the earlier recipients would
not. during delivery, the already open message file was used, to parse the
message. we still want to use that open message file, and the caller now stays
responsible for closing it, but we no longer try to rename (consume) the file.
we always hardlink (or copy) during delivery (this works on windows), and the
caller is responsible for closing and removing (in that order) the original
temporary file. this does cost one syscall more. but it makes the delivery code
(responsibilities) a bit simpler.
there is one more obvious issue: the file system path separator. mox already
used the "filepath" package to join paths in many places, but not everywhere.
and it still used strings with slashes for local file access. with this commit,
the code now uses filepath.FromSlash for path strings with slashes, uses
"filepath" in a few more places where it previously didn't. also switches from
"filepath" to regular "path" package when handling mailbox names in a few
places, because those always use forward slashes, regardless of local file
system conventions. windows can handle forward slashes when opening files, so
test code that passes path strings with forward slashes straight to go stdlib
file i/o functions are left unchanged to reduce code churn. the regular
non-test code, or test code that uses path strings in places other than
standard i/o functions, does have the paths converted for consistent paths
(otherwise we would end up with paths with mixed forward/backward slashes in
log messages).
windows cannot dup a listening socket. for "mox localserve", it isn't
important, and we can work around the issue. the current approach for "mox
serve" (forking a process and passing file descriptors of listening sockets on
"privileged" ports) won't work on windows. perhaps it isn't needed on windows,
and any user can listen on "privileged" ports? that would be welcome.
on windows, os.Open cannot open a directory, so we cannot call Sync on it after
message delivery. a cursory internet search indicates that directories cannot
be synced on windows. the story is probably much more nuanced than that, with
long deep technical details/discussions/disagreement/confusion, like on unix.
for "mox localserve" we can get away with making syncdir a no-op.
2023-10-14 11:54:07 +03:00
mox . ConfigStaticPath = filepath . FromSlash ( "../testdata/webmail/mox.conf" )
add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
mox . MustLoadConfig ( true , false )
2023-08-08 00:14:31 +03:00
defer store . Switchboard ( ) ( )
add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
acc , err := store . OpenAccount ( "mjl" )
tcheck ( t , err , "open account" )
err = acc . SetPassword ( "test1234" )
tcheck ( t , err , "set password" )
defer func ( ) {
err := acc . Close ( )
xlog . Check ( err , "closing account" )
} ( )
var zerom store . Message
var (
inboxMinimal = & testmsg { "Inbox" , store . Flags { } , nil , msgMinimal , zerom , 0 }
inboxText = & testmsg { "Inbox" , store . Flags { } , nil , msgText , zerom , 0 }
inboxHTML = & testmsg { "Inbox" , store . Flags { } , nil , msgHTML , zerom , 0 }
inboxAlt = & testmsg { "Inbox" , store . Flags { } , nil , msgAlt , zerom , 0 }
inboxAltRel = & testmsg { "Inbox" , store . Flags { } , nil , msgAltRel , zerom , 0 }
inboxAttachments = & testmsg { "Inbox" , store . Flags { } , nil , msgAttachments , zerom , 0 }
testbox1Alt = & testmsg { "Testbox1" , store . Flags { } , nil , msgAlt , zerom , 0 }
rejectsMinimal = & testmsg { "Rejects" , store . Flags { Junk : true } , nil , msgMinimal , zerom , 0 }
)
var testmsgs = [ ] * testmsg { inboxMinimal , inboxText , inboxHTML , inboxAlt , inboxAltRel , inboxAttachments , testbox1Alt , rejectsMinimal }
for _ , tm := range testmsgs {
tdeliver ( t , acc , tm )
}
api := Webmail { maxMessageSize : 1024 * 1024 }
reqInfo := requestInfo { "mjl@mox.example" , "mjl" , & http . Request { } }
ctx := context . WithValue ( ctxbg , requestInfoCtxKey , reqInfo )
// FlagsAdd
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` \seen ` , ` customlabel ` } )
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID , inboxHTML . ID } , [ ] string { ` \seen ` , ` customlabel ` } )
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID , inboxText . ID } , [ ] string { ` \seen ` , ` customlabel ` } ) // Same message twice.
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` another ` } )
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` another ` } ) // No change.
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { } ) // Nothing to do.
api . FlagsAdd ( ctx , [ ] int64 { } , [ ] string { } ) // No messages, no flags.
api . FlagsAdd ( ctx , [ ] int64 { } , [ ] string { ` custom ` } ) // No message, new flag.
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` $junk ` } ) // Trigger retrain.
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` $notjunk ` } ) // Trigger retrain.
api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID , testbox1Alt . ID } , [ ] string { ` $junk ` , ` $notjunk ` } ) // Trigger retrain, messages in different mailboxes.
api . FlagsAdd ( ctx , [ ] int64 { inboxHTML . ID , testbox1Alt . ID } , [ ] string { ` \Seen ` , ` newlabel ` } ) // Two mailboxes with counts and keywords changed.
tneedError ( t , func ( ) { api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` bad syntax ` } ) } )
tneedError ( t , func ( ) { api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` ` } ) } ) // Empty is invalid.
tneedError ( t , func ( ) { api . FlagsAdd ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` \unknownsystem ` } ) } ) // Only predefined system flags.
// FlagsClear, inverse of FlagsAdd.
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` \seen ` , ` customlabel ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID , inboxHTML . ID } , [ ] string { ` \seen ` , ` customlabel ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID , inboxText . ID } , [ ] string { ` \seen ` , ` customlabel ` } ) // Same message twice.
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` another ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` another ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { } )
api . FlagsClear ( ctx , [ ] int64 { } , [ ] string { } )
api . FlagsClear ( ctx , [ ] int64 { } , [ ] string { ` custom ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` $junk ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` $notjunk ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxText . ID , testbox1Alt . ID } , [ ] string { ` $junk ` , ` $notjunk ` } )
api . FlagsClear ( ctx , [ ] int64 { inboxHTML . ID , testbox1Alt . ID } , [ ] string { ` \Seen ` } ) // Two mailboxes with counts changed.
tneedError ( t , func ( ) { api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` bad syntax ` } ) } )
tneedError ( t , func ( ) { api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` ` } ) } )
tneedError ( t , func ( ) { api . FlagsClear ( ctx , [ ] int64 { inboxText . ID } , [ ] string { ` \unknownsystem ` } ) } )
// MailboxSetSpecialUse
var inbox , archive , sent , testbox1 store . Mailbox
err = acc . DB . Read ( ctx , func ( tx * bstore . Tx ) error {
get := func ( k string , v any ) store . Mailbox {
mb , err := bstore . QueryTx [ store . Mailbox ] ( tx ) . FilterEqual ( k , v ) . Get ( )
tcheck ( t , err , "get special-use mailbox" )
return mb
}
get ( "Draft" , true )
sent = get ( "Sent" , true )
archive = get ( "Archive" , true )
get ( "Trash" , true )
get ( "Junk" , true )
inbox = get ( "Name" , "Inbox" )
testbox1 = get ( "Name" , "Testbox1" )
return nil
} )
tcheck ( t , err , "get mailboxes" )
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : archive . ID , SpecialUse : store . SpecialUse { Draft : true } } ) // Already set.
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Draft : true } } ) // New draft mailbox.
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Sent : true } } )
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Archive : true } } )
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Trash : true } } )
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Junk : true } } )
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { } } ) // None
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { Draft : true , Sent : true , Archive : true , Trash : true , Junk : true } } ) // All
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : testbox1 . ID , SpecialUse : store . SpecialUse { } } ) // None again.
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : sent . ID , SpecialUse : store . SpecialUse { Sent : true } } ) // Sent, for sending mail later.
tneedError ( t , func ( ) { api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : 0 } ) } )
// MailboxRename
api . MailboxRename ( ctx , testbox1 . ID , "Testbox2" )
api . MailboxRename ( ctx , testbox1 . ID , "Test/A/B/Box1" )
api . MailboxRename ( ctx , testbox1 . ID , "Test/A/Box1" )
api . MailboxRename ( ctx , testbox1 . ID , "Testbox1" )
tneedError ( t , func ( ) { api . MailboxRename ( ctx , 0 , "BadID" ) } )
tneedError ( t , func ( ) { api . MailboxRename ( ctx , testbox1 . ID , "Testbox1" ) } ) // Already this name.
tneedError ( t , func ( ) { api . MailboxRename ( ctx , testbox1 . ID , "Inbox" ) } ) // Inbox not allowed.
tneedError ( t , func ( ) { api . MailboxRename ( ctx , inbox . ID , "Binbox" ) } ) // Inbox not allowed.
tneedError ( t , func ( ) { api . MailboxRename ( ctx , testbox1 . ID , "Archive" ) } ) // Exists.
// ParsedMessage
// todo: verify contents
api . ParsedMessage ( ctx , inboxMinimal . ID )
api . ParsedMessage ( ctx , inboxText . ID )
api . ParsedMessage ( ctx , inboxHTML . ID )
api . ParsedMessage ( ctx , inboxAlt . ID )
api . ParsedMessage ( ctx , inboxAltRel . ID )
api . ParsedMessage ( ctx , testbox1Alt . ID )
tneedError ( t , func ( ) { api . ParsedMessage ( ctx , 0 ) } )
tneedError ( t , func ( ) { api . ParsedMessage ( ctx , testmsgs [ len ( testmsgs ) - 1 ] . ID + 1 ) } )
// MailboxDelete
api . MailboxDelete ( ctx , testbox1 . ID )
testa , err := bstore . QueryDB [ store . Mailbox ] ( ctx , acc . DB ) . FilterEqual ( "Name" , "Test/A" ) . Get ( )
tcheck ( t , err , "get mailbox Test/A" )
tneedError ( t , func ( ) { api . MailboxDelete ( ctx , testa . ID ) } ) // Test/A/B still exists.
tneedError ( t , func ( ) { api . MailboxDelete ( ctx , 0 ) } ) // Bad ID.
tneedError ( t , func ( ) { api . MailboxDelete ( ctx , testbox1 . ID ) } ) // No longer exists.
tneedError ( t , func ( ) { api . MailboxDelete ( ctx , inbox . ID ) } ) // Cannot remove inbox.
tneedError ( t , func ( ) { api . ParsedMessage ( ctx , testbox1Alt . ID ) } ) // Message was removed and no longer exists.
api . MailboxCreate ( ctx , "Testbox1" )
testbox1 , err = bstore . QueryDB [ store . Mailbox ] ( ctx , acc . DB ) . FilterEqual ( "Name" , "Testbox1" ) . Get ( )
tcheck ( t , err , "get testbox1" )
tdeliver ( t , acc , testbox1Alt )
// MailboxEmpty
api . MailboxEmpty ( ctx , testbox1 . ID )
tneedError ( t , func ( ) { api . ParsedMessage ( ctx , testbox1Alt . ID ) } ) // Message was removed and no longer exists.
tneedError ( t , func ( ) { api . MailboxEmpty ( ctx , 0 ) } ) // Bad ID.
// MessageMove
tneedError ( t , func ( ) { api . MessageMove ( ctx , [ ] int64 { testbox1Alt . ID } , inbox . ID ) } ) // Message was removed (with MailboxEmpty above).
api . MessageMove ( ctx , [ ] int64 { } , testbox1 . ID ) // No messages.
tdeliver ( t , acc , testbox1Alt )
tneedError ( t , func ( ) { api . MessageMove ( ctx , [ ] int64 { testbox1Alt . ID } , testbox1 . ID ) } ) // Already in destination mailbox.
tneedError ( t , func ( ) { api . MessageMove ( ctx , [ ] int64 { } , 0 ) } ) // Bad ID.
api . MessageMove ( ctx , [ ] int64 { inboxMinimal . ID , inboxHTML . ID } , testbox1 . ID )
api . MessageMove ( ctx , [ ] int64 { inboxMinimal . ID , inboxHTML . ID , testbox1Alt . ID } , inbox . ID ) // From different mailboxes.
api . FlagsAdd ( ctx , [ ] int64 { inboxMinimal . ID } , [ ] string { ` minimallabel ` } ) // For move.
api . MessageMove ( ctx , [ ] int64 { inboxMinimal . ID } , testbox1 . ID ) // Move causes new label for destination mailbox.
api . MessageMove ( ctx , [ ] int64 { rejectsMinimal . ID } , testbox1 . ID ) // Move causing readjustment of MailboxOrigID due to Rejects mailbox.
tneedError ( t , func ( ) { api . MessageMove ( ctx , [ ] int64 { testbox1Alt . ID , inboxMinimal . ID } , testbox1 . ID ) } ) // inboxMinimal already in destination.
// Restore.
api . MessageMove ( ctx , [ ] int64 { inboxMinimal . ID } , inbox . ID )
api . MessageMove ( ctx , [ ] int64 { testbox1Alt . ID } , testbox1 . ID )
// MessageDelete
api . MessageDelete ( ctx , [ ] int64 { } ) // No messages.
api . MessageDelete ( ctx , [ ] int64 { inboxMinimal . ID , inboxHTML . ID } ) // Same mailbox.
api . MessageDelete ( ctx , [ ] int64 { inboxText . ID , testbox1Alt . ID , inboxAltRel . ID } ) // Multiple mailboxes, multiple times.
tneedError ( t , func ( ) { api . MessageDelete ( ctx , [ ] int64 { 0 } ) } ) // Bad ID.
tneedError ( t , func ( ) { api . MessageDelete ( ctx , [ ] int64 { testbox1Alt . ID + 999 } ) } ) // Bad ID
tneedError ( t , func ( ) { api . MessageDelete ( ctx , [ ] int64 { testbox1Alt . ID } ) } ) // Already removed.
tdeliver ( t , acc , testbox1Alt )
tdeliver ( t , acc , inboxAltRel )
// MessageSubmit
queue . Localserve = true // Deliver directly to us instead attempting actual delivery.
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" , "mjl to2 <mjl+to2@mox.example>" } ,
Cc : [ ] string { "mjl+cc@mox.example" , "mjl cc2 <mjl+cc2@mox.example>" } ,
Bcc : [ ] string { "mjl+bcc@mox.example" , "mjl bcc2 <mjl+bcc2@mox.example>" } ,
Subject : "test email" ,
TextBody : "this is the content\n\ncheers,\nmox" ,
ReplyTo : "mjl replyto <mjl+replyto@mox.example>" ,
UserAgent : "moxwebmail/dev" ,
} )
// todo: check delivery of 6 messages to inbox, 1 to sent
// Reply with attachments.
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
Subject : "Re: reply with attachments" ,
TextBody : "sending you these fake png files" ,
Attachments : [ ] File {
{
Filename : "test1.png" ,
DataURI : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUg==" ,
} ,
{
Filename : "test1.png" ,
DataURI : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUg==" ,
} ,
} ,
ResponseMessageID : testbox1Alt . ID ,
} )
// todo: check answered flag
// Forward with attachments.
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
Subject : "Fwd: the original subject" ,
TextBody : "look what i got" ,
Attachments : [ ] File {
{
Filename : "test1.png" ,
DataURI : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUg==" ,
} ,
} ,
ForwardAttachments : ForwardAttachments {
MessageID : inboxAltRel . ID ,
Paths : [ ] [ ] int { { 1 , 1 } , { 1 , 1 } } ,
} ,
IsForward : true ,
ResponseMessageID : testbox1Alt . ID ,
} )
// todo: check forwarded flag, check it has the right attachments.
// Send from utf8 localpart.
api . MessageSubmit ( ctx , SubmitMessage {
From : "møx@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
TextBody : "test" ,
} )
// Send to utf8 localpart.
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "møx@mox.example" } ,
TextBody : "test" ,
} )
// Send to utf-8 text.
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
Subject : "hi ☺" ,
TextBody : fmt . Sprintf ( "%80s" , "tést" ) ,
} )
// Send without special-use Sent mailbox.
api . MailboxSetSpecialUse ( ctx , store . Mailbox { ID : sent . ID , SpecialUse : store . SpecialUse { } } )
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
Subject : "hi ☺" ,
TextBody : fmt . Sprintf ( "%80s" , "tést" ) ,
} )
// Message with From-address of another account.
tneedError ( t , func ( ) {
api . MessageSubmit ( ctx , SubmitMessage {
From : "other@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
TextBody : "test" ,
} )
} )
// Message with unknown address.
tneedError ( t , func ( ) {
api . MessageSubmit ( ctx , SubmitMessage {
From : "doesnotexist@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
TextBody : "test" ,
} )
} )
// Message without recipient.
tneedError ( t , func ( ) {
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
TextBody : "test" ,
} )
} )
api . maxMessageSize = 1
tneedError ( t , func ( ) {
api . MessageSubmit ( ctx , SubmitMessage {
From : "mjl@mox.example" ,
To : [ ] string { "mjl+to@mox.example" } ,
Subject : "too large" ,
TextBody : "so many bytes" ,
} )
} )
api . maxMessageSize = 1024 * 1024
// Hit recipient limit.
tneedError ( t , func ( ) {
accConf , _ := acc . Conf ( )
for i := 0 ; i <= accConf . MaxFirstTimeRecipientsPerDay ; i ++ {
api . MessageSubmit ( ctx , SubmitMessage {
From : fmt . Sprintf ( "user@mox%d.example" , i ) ,
TextBody : "test" ,
} )
}
} )
// Hit message limit.
tneedError ( t , func ( ) {
accConf , _ := acc . Conf ( )
for i := 0 ; i <= accConf . MaxOutgoingMessagesPerDay ; i ++ {
api . MessageSubmit ( ctx , SubmitMessage {
From : fmt . Sprintf ( "user@mox%d.example" , i ) ,
TextBody : "test" ,
} )
}
} )
l , full := api . CompleteRecipient ( ctx , "doesnotexist" )
tcompare ( t , len ( l ) , 0 )
tcompare ( t , full , true )
l , full = api . CompleteRecipient ( ctx , "cc2" )
tcompare ( t , l , [ ] string { "mjl cc2 <mjl+cc2@mox.example>" } )
tcompare ( t , full , true )
2023-10-15 16:05:20 +03:00
// RecipientSecurity
resolver := dns . MockResolver { }
implement "requiretls", rfc 8689
with requiretls, the tls verification mode/rules for email deliveries can be
changed by the sender/submitter. in two ways:
1. "requiretls" smtp extension to always enforce verified tls (with mta-sts or
dnssec+dane), along the entire delivery path until delivery into the final
destination mailbox (so entire transport is verified-tls-protected).
2. "tls-required: no" message header, to ignore any tls and tls verification
errors even if the recipient domain has a policy that requires tls verification
(mta-sts and/or dnssec+dane), allowing delivery of non-sensitive messages in
case of misconfiguration/interoperability issues (at least useful for sending
tls reports).
we enable requiretls by default (only when tls is active), for smtp and
submission. it can be disabled through the config.
for each delivery attempt, we now store (per recipient domain, in the account
of the sender) whether the smtp server supports starttls and requiretls. this
support is shown (after having sent a first message) in the webmail when
sending a message (the previous 3 bars under the address input field are now 5
bars, the first for starttls support, the last for requiretls support). when
all recipient domains for a message are known to implement requiretls,
requiretls is automatically selected for sending (instead of "default" tls
behaviour). users can also select the "fallback to insecure" to add the
"tls-required: no" header.
new metrics are added for insight into requiretls errors and (some, not yet
all) cases where tls-required-no ignored a tls/verification error.
the admin can change the requiretls status for messages in the queue. so with
default delivery attempts, when verified tls is required by failing, an admin
could potentially change the field to "tls-required: no"-behaviour.
messages received (over smtp) with the requiretls option, get a comment added
to their Received header line, just before "id", after "with".
2023-10-24 11:06:16 +03:00
rs , err := recipientSecurity ( ctx , resolver , "mjl@a.mox.example" )
2023-10-15 16:05:20 +03:00
tcompare ( t , err , nil )
implement "requiretls", rfc 8689
with requiretls, the tls verification mode/rules for email deliveries can be
changed by the sender/submitter. in two ways:
1. "requiretls" smtp extension to always enforce verified tls (with mta-sts or
dnssec+dane), along the entire delivery path until delivery into the final
destination mailbox (so entire transport is verified-tls-protected).
2. "tls-required: no" message header, to ignore any tls and tls verification
errors even if the recipient domain has a policy that requires tls verification
(mta-sts and/or dnssec+dane), allowing delivery of non-sensitive messages in
case of misconfiguration/interoperability issues (at least useful for sending
tls reports).
we enable requiretls by default (only when tls is active), for smtp and
submission. it can be disabled through the config.
for each delivery attempt, we now store (per recipient domain, in the account
of the sender) whether the smtp server supports starttls and requiretls. this
support is shown (after having sent a first message) in the webmail when
sending a message (the previous 3 bars under the address input field are now 5
bars, the first for starttls support, the last for requiretls support). when
all recipient domains for a message are known to implement requiretls,
requiretls is automatically selected for sending (instead of "default" tls
behaviour). users can also select the "fallback to insecure" to add the
"tls-required: no" header.
new metrics are added for insight into requiretls errors and (some, not yet
all) cases where tls-required-no ignored a tls/verification error.
the admin can change the requiretls status for messages in the queue. so with
default delivery attempts, when verified tls is required by failing, an admin
could potentially change the field to "tls-required: no"-behaviour.
messages received (over smtp) with the requiretls option, get a comment added
to their Received header line, just before "id", after "with".
2023-10-24 11:06:16 +03:00
tcompare ( t , rs , RecipientSecurity { SecurityResultUnknown , SecurityResultNo , SecurityResultNo , SecurityResultNo , SecurityResultUnknown } )
err = acc . DB . Insert ( ctx , & store . RecipientDomainTLS { Domain : "a.mox.example" , STARTTLS : true , RequireTLS : false } )
tcheck ( t , err , "insert recipient domain tls info" )
rs , err = recipientSecurity ( ctx , resolver , "mjl@a.mox.example" )
tcompare ( t , err , nil )
tcompare ( t , rs , RecipientSecurity { SecurityResultYes , SecurityResultNo , SecurityResultNo , SecurityResultNo , SecurityResultNo } )
add webmail
it was far down on the roadmap, but implemented earlier, because it's
interesting, and to help prepare for a jmap implementation. for jmap we need to
implement more client-like functionality than with just imap. internal data
structures need to change. jmap has lots of other requirements, so it's already
a big project. by implementing a webmail now, some of the required data
structure changes become clear and can be made now, so the later jmap
implementation can do things similarly to the webmail code. the webmail
frontend and webmail are written together, making their interface/api much
smaller and simpler than jmap.
one of the internal changes is that we now keep track of per-mailbox
total/unread/unseen/deleted message counts and mailbox sizes. keeping this
data consistent after any change to the stored messages (through the code base)
is tricky, so mox now has a consistency check that verifies the counts are
correct, which runs only during tests, each time an internal account reference
is closed. we have a few more internal "changes" that are propagated for the
webmail frontend (that imap doesn't have a way to propagate on a connection),
like changes to the special-use flags on mailboxes, and used keywords in a
mailbox. more changes that will be required have revealed themselves while
implementing the webmail, and will be implemented next.
the webmail user interface is modeled after the mail clients i use or have
used: thunderbird, macos mail, mutt; and webmails i normally only use for
testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed,
but still the goal is to make this webmail client easy to use for everyone. the
user interface looks like most other mail clients: a list of mailboxes, a
search bar, a message list view, and message details. there is a top/bottom and
a left/right layout for the list/message view, default is automatic based on
screen size. the panes can be resized by the user. buttons for actions are just
text, not icons. clicking a button briefly shows the shortcut for the action in
the bottom right, helping with learning to operate quickly. any text that is
underdotted has a title attribute that causes more information to be displayed,
e.g. what a button does or a field is about. to highlight potential phishing
attempts, any text (anywhere in the webclient) that switches unicode "blocks"
(a rough approximation to (language) scripts) within a word is underlined
orange. multiple messages can be selected with familiar ui interaction:
clicking while holding control and/or shift keys. keyboard navigation works
with arrows/page up/down and home/end keys, and also with a few basic vi-like
keys for list/message navigation. we prefer showing the text instead of
html (with inlined images only) version of a message. html messages are shown
in an iframe served from an endpoint with CSP headers to prevent dangerous
resources (scripts, external images) from being loaded. the html is also
sanitized, with javascript removed. a user can choose to load external
resources (e.g. images for tracking purposes).
the frontend is just (strict) typescript, no external frameworks. all
incoming/outgoing data is typechecked, both the api request parameters and
response types, and the data coming in over SSE. the types and checking code
are generated with sherpats, which uses the api definitions generated by
sherpadoc based on the Go code. so types from the backend are automatically
propagated to the frontend. since there is no framework to automatically
propagate properties and rerender components, changes coming in over the SSE
connection are propagated explicitly with regular function calls. the ui is
separated into "views", each with a "root" dom element that is added to the
visible document. these views have additional functions for getting changes
propagated, often resulting in the view updating its (internal) ui state (dom).
we keep the frontend compilation simple, it's just a few typescript files that
get compiled (combined and types stripped) into a single js file, no additional
runtime code needed or complicated build processes used. the webmail is served
is served from a compressed, cachable html file that includes style and the
javascript, currently just over 225kb uncompressed, under 60kb compressed (not
minified, including comments). we include the generated js files in the
repository, to keep Go's easily buildable self-contained binaries.
authentication is basic http, as with the account and admin pages. most data
comes in over one long-term SSE connection to the backend. api requests signal
which mailbox/search/messages are requested over the SSE connection. fetching
individual messages, and making changes, are done through api calls. the
operations are similar to imap, so some code has been moved from package
imapserver to package store. the future jmap implementation will benefit from
these changes too. more functionality will probably be moved to the store
package in the future.
the quickstart enables webmail on the internal listener by default (for new
installs). users can enable it on the public listener if they want to. mox
localserve enables it too. to enable webmail on existing installs, add settings
like the following to the listeners in mox.conf, similar to AccountHTTP(S):
WebmailHTTP:
Enabled: true
WebmailHTTPS:
Enabled: true
special thanks to liesbeth, gerben, andrii for early user feedback.
there is plenty still to do, see the list at the top of webmail/webmail.ts.
feedback welcome as always.
2023-08-07 22:57:03 +03:00
}