forgejo/routers/web
zeripath 93ab90743d
Prevent loop if there is an error in GetNotificationCount ()
If the context is cancelled `.NotificationUnreadCount` in a template can
cause an infinite loop with `ctx.ServerError()` being called, which
creates a template that then calls `.NotificationUnreadCount` calling
`GetNotificationCount()` with the cancelled context resulting in an
error that calls `ctx.ServerError`... and so on...

This PR simply stops calling `ctx.ServerError` in the error handler code
for `.NotificationUnreadCount` as we have already started rendering and
so it is too late to call `ctx.ServerError`. Additionally we skip
logging the error if it's a context cancelled error.

Fix 

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-05-25 08:51:53 +08:00
..
admin Move almost all functions' parameter db.Engine to context.Context () 2022-05-20 22:08:52 +08:00
auth Prevent NPE when cache service is disabled () 2022-05-21 22:29:49 +08:00
dev Move user related model into models/user () 2021-11-24 17:49:20 +08:00
events Improve Stopwatch behavior () 2022-04-25 22:45:22 +02:00
explore Remove RequireHighlightJS field, update plantuml example. () 2022-05-05 10:53:38 +03:00
feed Add ContextUser to http request context () 2022-03-26 17:04:22 +08:00
healthcheck Update go-chi/cache to utilize Ping() () 2022-05-15 20:43:27 +02:00
misc Fix panic in team repos API () 2022-04-20 18:43:26 +08:00
org Move almost all functions' parameter db.Engine to context.Context () 2022-05-20 22:08:52 +08:00
repo Move almost all functions' parameter db.Engine to context.Context () 2022-05-20 22:08:52 +08:00
user Prevent loop if there is an error in GetNotificationCount () 2022-05-25 08:51:53 +08:00
auth.go Remove legacy +build: constraint () 2022-05-02 23:22:45 +08:00
auth_windows.go Let web and API routes have different auth methods group () 2022-03-28 12:46:28 +08:00
base.go Update base.go () 2022-05-19 11:20:34 -04:00
goget.go Refactor legacy unknwon/com package, improve golangci lint () 2022-04-01 16:47:50 +08:00
home.go Renamed ctx.User to ctx.Doer. () 2022-03-22 15:03:22 +08:00
metrics.go Update HTTP status codes to modern codes () 2022-03-23 12:54:07 +08:00
nodeinfo.go Add nodeinfo endpoint for federation purposes () 2021-09-28 01:38:06 +02:00
swagger_json.go
web.go Add Webfinger endpoint () 2022-05-09 20:20:21 +02:00
webfinger.go Move almost all functions' parameter db.Engine to context.Context () 2022-05-20 22:08:52 +08:00