mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-27 14:13:52 +03:00
3fdaabcdcf
Fix #31657. According to the [doc](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onschedule) of GitHub Actions, The timezone for cron should be UTC, not the local timezone. And Gitea Actions doesn't have any reasons to change this, so I think it's a bug. However, Gitea Actions has extended the syntax, as it supports descriptors like `@weekly` and `@every 5m`, and supports specifying the timezone like `TZ=UTC 0 10 * * *`. So we can make it use UTC only when the timezone is not specified, to be compatible with GitHub Actions, and also respect the user's specified. It does break the feature because the times to run tasks would be changed, and it may confuse users. So I don't think we should backport this. ## ⚠️ BREAKING ⚠️ If the server's local time zone is not UTC, a scheduled task would run at a different time after upgrading Gitea to this version. (cherry picked from commit 21a73ae642b15982a911837775c9583deb47220c)
138 lines
3.7 KiB
Go
138 lines
3.7 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
webhook_module "code.gitea.io/gitea/modules/webhook"
|
|
)
|
|
|
|
// ActionSchedule represents a schedule of a workflow file
|
|
type ActionSchedule struct {
|
|
ID int64
|
|
Title string
|
|
Specs []string
|
|
RepoID int64 `xorm:"index"`
|
|
Repo *repo_model.Repository `xorm:"-"`
|
|
OwnerID int64 `xorm:"index"`
|
|
WorkflowID string
|
|
TriggerUserID int64
|
|
TriggerUser *user_model.User `xorm:"-"`
|
|
Ref string
|
|
CommitSHA string
|
|
Event webhook_module.HookEventType
|
|
EventPayload string `xorm:"LONGTEXT"`
|
|
Content []byte
|
|
Created timeutil.TimeStamp `xorm:"created"`
|
|
Updated timeutil.TimeStamp `xorm:"updated"`
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(ActionSchedule))
|
|
}
|
|
|
|
// GetSchedulesMapByIDs returns the schedules by given id slice.
|
|
func GetSchedulesMapByIDs(ctx context.Context, ids []int64) (map[int64]*ActionSchedule, error) {
|
|
schedules := make(map[int64]*ActionSchedule, len(ids))
|
|
return schedules, db.GetEngine(ctx).In("id", ids).Find(&schedules)
|
|
}
|
|
|
|
// GetReposMapByIDs returns the repos by given id slice.
|
|
func GetReposMapByIDs(ctx context.Context, ids []int64) (map[int64]*repo_model.Repository, error) {
|
|
repos := make(map[int64]*repo_model.Repository, len(ids))
|
|
return repos, db.GetEngine(ctx).In("id", ids).Find(&repos)
|
|
}
|
|
|
|
// CreateScheduleTask creates new schedule task.
|
|
func CreateScheduleTask(ctx context.Context, rows []*ActionSchedule) error {
|
|
// Return early if there are no rows to insert
|
|
if len(rows) == 0 {
|
|
return nil
|
|
}
|
|
|
|
// Begin transaction
|
|
ctx, committer, err := db.TxContext(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer committer.Close()
|
|
|
|
// Loop through each schedule row
|
|
for _, row := range rows {
|
|
// Create new schedule row
|
|
if err = db.Insert(ctx, row); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Loop through each schedule spec and create a new spec row
|
|
now := time.Now()
|
|
|
|
for _, spec := range row.Specs {
|
|
specRow := &ActionScheduleSpec{
|
|
RepoID: row.RepoID,
|
|
ScheduleID: row.ID,
|
|
Spec: spec,
|
|
}
|
|
// Parse the spec and check for errors
|
|
schedule, err := specRow.Parse()
|
|
if err != nil {
|
|
continue // skip to the next spec if there's an error
|
|
}
|
|
|
|
specRow.Next = timeutil.TimeStamp(schedule.Next(now).Unix())
|
|
|
|
// Insert the new schedule spec row
|
|
if err = db.Insert(ctx, specRow); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
// Commit transaction
|
|
return committer.Commit()
|
|
}
|
|
|
|
func DeleteScheduleTaskByRepo(ctx context.Context, id int64) error {
|
|
ctx, committer, err := db.TxContext(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer committer.Close()
|
|
|
|
if _, err := db.GetEngine(ctx).Delete(&ActionSchedule{RepoID: id}); err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err := db.GetEngine(ctx).Delete(&ActionScheduleSpec{RepoID: id}); err != nil {
|
|
return err
|
|
}
|
|
|
|
return committer.Commit()
|
|
}
|
|
|
|
func CleanRepoScheduleTasks(ctx context.Context, repo *repo_model.Repository) error {
|
|
// If actions disabled when there is schedule task, this will remove the outdated schedule tasks
|
|
// There is no other place we can do this because the app.ini will be changed manually
|
|
if err := DeleteScheduleTaskByRepo(ctx, repo.ID); err != nil {
|
|
return fmt.Errorf("DeleteCronTaskByRepo: %v", err)
|
|
}
|
|
// cancel running cron jobs of this repository and delete old schedules
|
|
if err := CancelPreviousJobs(
|
|
ctx,
|
|
repo.ID,
|
|
repo.DefaultBranch,
|
|
"",
|
|
webhook_module.HookEventSchedule,
|
|
); err != nil {
|
|
return fmt.Errorf("CancelPreviousJobs: %v", err)
|
|
}
|
|
return nil
|
|
}
|