forgejo/routers/web/repo
Giteabot 571822b6ec
Fix issue dependencies () ()
Backport  by @lng2020

Fix  
Fix 
Fix  
Fix  
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
2024-01-12 23:29:22 +02:00
..
actions Only check online runner when detecting matching runners in workflows () () 2023-12-19 04:06:31 +00:00
setting Fix comment permissions () () 2023-11-25 23:43:23 +00:00
activity.go
attachment.go
blame.go Use information from previous blame parts () () 2023-12-22 06:47:34 +08:00
branch.go Also sync DB branches on push if necessary () () 2023-12-11 06:16:56 +00:00
cherry_pick.go
commit.go
compare.go
download.go
editor.go Revert "Fix EOL handling in web editor" () () 2023-11-22 18:06:13 +08:00
editor_test.go
find.go
githttp.go
githttp_test.go
helper.go
helper_test.go
issue.go Fix issue dependencies () () 2024-01-12 23:29:22 +02:00
issue_content_history.go Fix missing check () () 2023-12-11 09:10:48 +08:00
issue_dependency.go
issue_label.go
issue_label_test.go
issue_lock.go
issue_pin.go Fix missing check () () 2023-12-11 09:10:48 +08:00
issue_stopwatch.go
issue_test.go
issue_timetrack.go
issue_watch.go
main_test.go
middlewares.go
migrate.go
milestone.go
packages.go
patch.go
projects.go Fix comment permissions () () 2023-11-25 23:43:23 +00:00
projects_test.go
pull.go Fix status_check_contexts matching bug () () 2023-12-22 23:32:22 +08:00
pull_review.go
release.go Fix comment permissions () () 2023-11-25 23:43:23 +00:00
release_test.go
render.go
repo.go
search.go
topic.go
treelist.go
view.go Add option to disable ambiguous unicode characters detection () () 2023-12-18 12:20:37 +08:00
view_test.go
wiki.go
wiki_test.go