forgejo/modules/migration
Yarden Shoham 37bbf2c902
Fix restore repo bug, clarify the problem of ForeignIndex () ()
Backport 

Fix 

TLDR:  made a mess with ForeignIndex and triggered a design
flaw/bug of , then a quick patch  helped , then the
the bug was re-triggered by  .

Related:
* 
* BasicIssueContext
https://github.com/go-gitea/gitea/pull/16356/files#diff-7938eb670d42a5ead6b08121e16aa4537a4d716c1cf37923c70470020fb9d036R16-R27
*  
* If some issues were dumped without ForeignIndex, then they would be
imported as ForeignIndex=0
https://github.com/go-gitea/gitea/pull/18446/files#diff-1624a3e715d8fc70edf2db1630642b7d6517f8c359cc69d58c3958b34ba4ce5eR38-R39
* 
* It patched the above bug (somewhat), made the issues without
ForeignIndex could have the same value as LocalIndex
*  
    * It re-triggered the zero-ForeignIndex bug.


ps: I am not sure whether the changes in `GetForeignIndex` are ideal (at
least, now it has almost the same behavior as BasicIssueContext in
), it's just a quick fix. Feel free to edit on this PR directly or
replace it.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-02-08 08:39:42 +00:00
..
file_format_testdata Validate migration files () 2022-01-26 10:45:51 +01:00
schemas Validate migration files () 2022-01-26 10:45:51 +01:00
comment.go Fix restore repo bug, clarify the problem of ForeignIndex () () 2023-02-08 08:39:42 +00:00
downloader.go Store the foreign ID of issues during migration () 2022-03-17 18:08:35 +01:00
error.go Move migrations into services and base into modules/migration () 2021-11-16 23:25:33 +08:00
file_format.go Validate migration files () 2022-01-26 10:45:51 +01:00
file_format_test.go Validate migration files () 2022-01-26 10:45:51 +01:00
issue.go Fix restore repo bug, clarify the problem of ForeignIndex () () 2023-02-08 08:39:42 +00:00
label.go Validate migration files () 2022-01-26 10:45:51 +01:00
messenger.go Move migrations into services and base into modules/migration () 2021-11-16 23:25:33 +08:00
milestone.go Validate migration files () 2022-01-26 10:45:51 +01:00
null_downloader.go Fix dump-repo git init, fix wrong error type for NullDownloader () 2022-07-01 07:48:25 +08:00
options.go Move migrations into services and base into modules/migration () 2021-11-16 23:25:33 +08:00
pullrequest.go Add more checks in migration code () 2022-09-04 13:47:56 +03:00
reaction.go add test coverage for original author conversion during migrations () 2022-02-01 13:20:28 -05:00
release.go Add more checks in migration code () 2022-09-04 13:47:56 +03:00
repo.go Add more checks in migration code () 2022-09-04 13:47:56 +03:00
retry_downloader.go Store the foreign ID of issues during migration () 2022-03-17 18:08:35 +01:00
review.go Fix restore repo bug, clarify the problem of ForeignIndex () () 2023-02-08 08:39:42 +00:00
schemas_bindata.go Remove legacy +build: constraint () 2022-05-02 23:22:45 +08:00
schemas_dynamic.go Remove legacy +build: constraint () 2022-05-02 23:22:45 +08:00
schemas_static.go Remove legacy +build: constraint () 2022-05-02 23:22:45 +08:00
uploader.go Move migrations into services and base into modules/migration () 2021-11-16 23:25:33 +08:00