serv/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-03-05 04:13:44 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions10
forgejo/modules/git
History
KN4CK3R 5f79550a0d
Prevent double use of git cat-file session. () 
Fixes the reason why  is hard to replicate.
Related 

Create a repo with a file with minimum size 4097 bytes (I use 10000) and
execute the following code:
```go
gitRepo, err := gitrepo.OpenRepository(db.DefaultContext, <repo>)
assert.NoError(t, err)

commit, err := gitRepo.GetCommit(<sha>)
assert.NoError(t, err)

entry, err := commit.GetTreeEntryByPath(<file>)
assert.NoError(t, err)

b := entry.Blob()

// Create a reader
r, err := b.DataAsync()
assert.NoError(t, err)
defer r.Close()

// Create a second reader
r2, err := b.DataAsync()
assert.NoError(t, err) // Should be no error but is ErrNotExist
defer r2.Close()
```

The problem is the check in `CatFileBatch`:

79217ea63c/modules/git/repo_base_nogogit.go (L81-L87)
`Buffered() > 0` is used to check if there is a "operation" in progress
at the moment. This is a problem because we can't control the internal
buffer in the `bufio.Reader`. The code above demonstrates a sequence
which initiates an operation for which the code thinks there is no
active processing. The second call to `DataAsync()` therefore reuses the
existing instances instead of creating a new batch reader.

(cherry picked from commit f74c869221624092999097af38b6f7fae4701420)
2024-02-26 22:30:25 +01:00
..
foreachref Use refname:strip-2 instead of refname:short when syncing tags () 2024-01-16 08:13:07 +01:00
internal
pipeline Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
tests/repos Add support for sha256 repositories () 2024-01-19 17:05:02 +01:00
url
batch_reader.go
blame.go
blame_sha256_test.go Fixes - Skipping SHA256 tests if unsupported 2024-02-24 00:14:24 +01:00
blame_test.go
blob.go
blob_gogit.go
blob_nogogit.go
blob_test.go
command.go
command_race_test.go
command_test.go
commit.go [GITEA] Detect file rename and show in history 2024-02-05 16:09:40 +01:00
commit_convert_gogit.go
commit_info.go
commit_info_gogit.go
commit_info_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
commit_info_test.go
commit_reader.go Add support for sha256 repositories () 2024-01-19 17:05:02 +01:00
commit_sha256_test.go Fixes - Skipping SHA256 tests if unsupported 2024-02-24 00:14:24 +01:00
commit_test.go [GITEA] Detect file rename and show in history 2024-02-05 16:09:40 +01:00
diff.go
diff_test.go
error.go Add merge style fast-forward-only () 2024-02-14 17:19:19 +01:00
git.go [BUG] Workaround borked Git version 2024-02-13 18:33:18 +01:00
git_test.go
hook.go
last_commit_cache.go [GITEA] Drop sha256-simd in favor of stdlib 2024-02-05 16:09:40 +01:00
last_commit_cache_gogit.go
last_commit_cache_nogogit.go
log_name_status.go [CLEANUP] make golangci-lint@v1.56.1 happy 2024-02-15 16:19:36 +01:00
notes.go
notes_gogit.go
notes_nogogit.go
notes_test.go
object_format.go Add support for sha256 repositories () 2024-01-19 17:05:02 +01:00
object_id.go Add support for sha256 repositories () 2024-01-19 17:05:02 +01:00
object_id_gogit.go Add support for sha256 repositories () 2024-01-19 17:05:02 +01:00
object_id_test.go
parse_gogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
parse_gogit_test.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
parse_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
parse_nogogit_test.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
README.md
ref.go
ref_test.go
remote.go
repo.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
repo_archive.go Fix archive creating LFS hooks and breaking pull requests () 2024-01-19 05:49:18 +00:00
repo_attribute.go Correctly support linguist-documentation=false 2024-02-26 14:18:33 +01:00
repo_attribute_test.go
repo_base.go Simplify how git repositories are opened () 2024-01-27 21:09:51 +01:00
repo_base_gogit.go Update go dependencies and fix go-git () 2024-01-23 05:40:00 +00:00
repo_base_nogogit.go Prevent double use of git cat-file session. () 2024-02-26 22:30:25 +01:00
repo_blame.go
repo_blob.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_blob_gogit.go
repo_blob_nogogit.go
repo_blob_test.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_branch.go Simplify how git repositories are opened () 2024-01-27 21:09:51 +01:00
repo_branch_gogit.go Simplify how git repositories are opened () 2024-01-27 21:09:51 +01:00
repo_branch_nogogit.go Simplify how git repositories are opened () 2024-01-27 21:09:51 +01:00
repo_branch_test.go
repo_commit.go Integration Test for Commit Search containing Square Brackets () 2024-01-11 11:04:45 +08:00
repo_commit_gogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_commit_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_commit_test.go
repo_commitgraph.go
repo_commitgraph_gogit.go Update go dependencies and fix go-git () 2024-01-23 05:40:00 +00:00
repo_compare.go
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_language_stats.go Convert linguist attribute handling to optional.Option 2024-02-26 12:52:59 +01:00
repo_language_stats_gogit.go Correctly support linguist-documentation=false 2024-02-26 14:18:33 +01:00
repo_language_stats_nogogit.go Correctly support linguist-documentation=false 2024-02-26 14:18:33 +01:00
repo_language_stats_test.go
repo_object.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_ref.go
repo_ref_gogit.go
repo_ref_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_ref_test.go
repo_stats.go
repo_stats_test.go
repo_tag.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
repo_tag_gogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_tag_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_tag_test.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
repo_test.go
repo_tree.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_tree_gogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
repo_tree_nogogit.go Improve ObjectFormat interface () 2023-12-19 07:20:47 +00:00
signature.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
signature_gogit.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
signature_nogogit.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
signature_test.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
submodule.go
submodule_test.go
tag.go [gitea] Refactor parseSignatureFromCommitLine () 2024-02-10 10:53:43 +01:00
tag_test.go
tree.go
tree_blob.go [GITEA] Find README.md for user profiles case insensitively 2024-02-05 16:09:42 +01:00
tree_blob_gogit.go
tree_blob_nogogit.go
tree_entry.go
tree_entry_gogit.go
tree_entry_mode.go
tree_entry_nogogit.go
tree_entry_test.go
tree_gogit.go
tree_nogogit.go
utils.go
utils_test.go gofmt-ed modules/git/utils_test.go due to linter 2024-02-24 15:53:38 +01:00

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.