From fc62992518158ca6ceb03a57db5b3767c8dc6fc5 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Sat, 29 Apr 2023 11:53:11 +0200
Subject: [PATCH] Skip known flaky `queue` tests on CI environment (#24419)
Random CI failures are annoying. It's better to just skip the affected
tests so maintainers can use their valuable time for more productive
topics.
Related: https://github.com/go-gitea/gitea/issues/23608
Related: https://github.com/go-gitea/gitea/issues/23977
Related: https://github.com/go-gitea/gitea/issues/18703
---
modules/queue/queue_channel_test.go | 4 ++++
modules/queue/unique_queue_disk_channel_test.go | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/modules/queue/queue_channel_test.go b/modules/queue/queue_channel_test.go
index 9b92398bac..f9dae742e2 100644
--- a/modules/queue/queue_channel_test.go
+++ b/modules/queue/queue_channel_test.go
@@ -4,6 +4,7 @@
package queue
import (
+ "os"
"sync"
"testing"
"time"
@@ -101,6 +102,9 @@ func TestChannelQueue_Batch(t *testing.T) {
}
func TestChannelQueue_Pause(t *testing.T) {
+ if os.Getenv("CI") != "" {
+ t.Skip("Skipping because test is flaky on CI")
+ }
lock := sync.Mutex{}
var queue Queue
var err error
diff --git a/modules/queue/unique_queue_disk_channel_test.go b/modules/queue/unique_queue_disk_channel_test.go
index f75c69f785..e2fe4aceee 100644
--- a/modules/queue/unique_queue_disk_channel_test.go
+++ b/modules/queue/unique_queue_disk_channel_test.go
@@ -4,6 +4,7 @@
package queue
import (
+ "os"
"strconv"
"sync"
"testing"
@@ -15,6 +16,10 @@ import (
)
func TestPersistableChannelUniqueQueue(t *testing.T) {
+ if os.Getenv("CI") != "" {
+ t.Skip("Skipping because test is flaky on CI")
+ }
+
tmpDir := t.TempDir()
_ = log.NewLogger(1000, "console", "console", `{"level":"warn","stacktracelevel":"NONE","stderr":true}`)