From dc9a3dfa851c8516404a2074007faba4dd1b110e Mon Sep 17 00:00:00 2001 From: a1012112796 <1012112796@qq.com> Date: Sat, 15 Jan 2022 18:13:16 +0800 Subject: [PATCH] update description about vendoring in CONTRIBUTING.md follow #18277 Signed-off-by: a1012112796 <1012112796@qq.com> --- CONTRIBUTING.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fad535bb2a..73c0ba278e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -91,13 +91,12 @@ Here's how to run the test suite: ## Vendoring -We keep a cached copy of dependencies within the `vendor/` directory, -managing updates via [Modules](https://golang.org/cmd/go/#hdr-Module_maintenance). +We managing updates via [Modules](https://golang.org/cmd/go/#hdr-Module_maintenance). -Pull requests should only include `vendor/` updates if they are part of +Pull requests should only include `go.mod`, `go.sum` updates if they are part of the same change, be it a bugfix or a feature addition. -The `vendor/` update needs to be justified as part of the PR description, +The `go.mod`, `go.sum` update needs to be justified as part of the PR description, and must be verified by the reviewers and/or merger to always reference an existing upstream commit.