From 953884236454e6e6a9e23dac21b8a4c124689723 Mon Sep 17 00:00:00 2001
From: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>
Date: Thu, 29 Jun 2023 00:00:19 +0200
Subject: [PATCH] Use correct response code in push mirror creation response in
v1_json.tmpl (#25476)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
In the process of doing a bit of automation via the API, we've
discovered a _small_ issue in the Swagger definition. We tried to create
a push mirror for a repository, but our generated client raised an
exception due to an unexpected status code.
When looking at this function:
https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L236-L240
We see it defines `201 - Created` as response:
https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L260-L262
But it actually returns `200 - OK`:
https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L373
So I've just updated the Swagger definitions to match the code😀
---------
Co-authored-by: Giteabot <teabot@gitea.io>
---
routers/api/v1/repo/mirror.go | 2 +-
templates/swagger/v1_json.tmpl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/routers/api/v1/repo/mirror.go b/routers/api/v1/repo/mirror.go
index 06bfabe3d2..9d8497927e 100644
--- a/routers/api/v1/repo/mirror.go
+++ b/routers/api/v1/repo/mirror.go
@@ -258,7 +258,7 @@ func AddPushMirror(ctx *context.APIContext) {
// schema:
// "$ref": "#/definitions/CreatePushMirrorOption"
// responses:
- // "201":
+ // "200":
// "$ref": "#/responses/PushMirror"
// "403":
// "$ref": "#/responses/forbidden"
diff --git a/templates/swagger/v1_json.tmpl b/templates/swagger/v1_json.tmpl
index e78c077fc3..11abeac77c 100644
--- a/templates/swagger/v1_json.tmpl
+++ b/templates/swagger/v1_json.tmpl
@@ -10729,7 +10729,7 @@
}
],
"responses": {
- "201": {
+ "200": {
"$ref": "#/responses/PushMirror"
},
"400": {