From 5c55793e0e76e0a878f001ad98a34099983d4cda Mon Sep 17 00:00:00 2001
From: Gary Kim <gary@garykim.dev>
Date: Sun, 24 May 2020 22:38:34 +0800
Subject: [PATCH] Fix wrong milestone in webhook message (#11596)
Fixes #11295
Signed-off-by: Gary Kim gary@garykim.dev
---
models/issue.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/models/issue.go b/models/issue.go
index d9f8e929c7..157ad48dee 100644
--- a/models/issue.go
+++ b/models/issue.go
@@ -249,7 +249,7 @@ func (issue *Issue) loadReactions(e Engine) (err error) {
}
func (issue *Issue) loadMilestone(e Engine) (err error) {
- if issue.Milestone == nil && issue.MilestoneID > 0 {
+ if (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
issue.Milestone, err = getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)
if err != nil && !IsErrMilestoneNotExist(err) {
return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %v", issue.RepoID, issue.MilestoneID, err)