serv/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-29 07:03:55 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Refactor copy button event handler (#29379)

Browse source 
Use "closest" instead of "for-loop"

(cherry picked from commit 736c98be5c2bed26cef9f7f679c49a95af8161ef)
This commit is contained in:
wxiaoguang 2024-02-25 12:17:11 +08:00 committed by Earl Warren
parent 110b06f88b
commit 29517c54e6
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 17 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
web_src/js/features/clipboard.js
View file

@ -5,18 +5,20 @@ import {clippie} from 'clippie';
const {copy_success, copy_error} = window.config.i18n; const {copy_success, copy_error} = window.config.i18n;
// Enable clipboard copy from HTML attributes. These properties are supported: // Enable clipboard copy from HTML attributes. These properties are supported:
// - data-clipboard-text: Direct text to copy, has highest precedence // - data-clipboard-text: Direct text to copy
// - data-clipboard-target: Holds a selector for a <input> or <textarea> whose content is copied // - data-clipboard-target: Holds a selector for a <input> or <textarea> whose content is copied
// - data-clipboard-text-type: When set to 'url' will convert relative to absolute urls // - data-clipboard-text-type: When set to 'url' will convert relative to absolute urls
export function initGlobalCopyToClipboardListener() { export function initGlobalCopyToClipboardListener() {
document.addEventListener('click', (e) => { document.addEventListener('click', async (e) => {
let target = e.target; const target = e.target.closest('[data-clipboard-text], [data-clipboard-target]');
// In case <button data-clipboard-text><svg></button>, so we just search if (!target) return;
// up to 3 levels for performance
for (let i = 0; i < 3 && target; i++) {
let text = target.getAttribute('data-clipboard-text');
if (!text && target.getAttribute('data-clipboard-target')) { e.preventDefault();
let text;
if (target.hasAttribute('data-clipboard-text')) {
text = target.getAttribute('data-clipboard-text');
} else {
text = document.querySelector(target.getAttribute('data-clipboard-target'))?.value; text = document.querySelector(target.getAttribute('data-clipboard-target'))?.value;
} }
@ -25,17 +27,8 @@ export function initGlobalCopyToClipboardListener() {
} }
if (text) { if (text) {
e.preventDefault();
(async() => {
const success = await clippie(text); const success = await clippie(text);
showTemporaryTooltip(target, success ? copy_success : copy_error); showTemporaryTooltip(target, success ? copy_success : copy_error);
})();
break;
}
target = target.parentElement;
} }
}); });
} }