serv/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-27 14:13:52 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix data-race bug when accessing task.LastRun (#27584)

Browse source
This commit is contained in:
wxiaoguang 2023-10-11 22:51:20 +08:00 committed by GitHub
parent fb74fe99d6
commit 1d155a43ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/cron/cron.go
View file

@ -107,12 +107,11 @@ func ListTasks() TaskTable {
prev = e.PreviousRun() prev = e.PreviousRun()
} }
task.lock.Lock()
// If the manual run is after the cron run, use that instead. // If the manual run is after the cron run, use that instead.
if prev.Before(task.LastRun) { if prev.Before(task.LastRun) {
prev = task.LastRun prev = task.LastRun
} }
task.lock.Lock()
tTable = append(tTable, &TaskTableRow{ tTable = append(tTable, &TaskTableRow{
Name: task.Name, Name: task.Name,
Spec: spec, Spec: spec,