From 16afe4f63181a68565785c04885ed7d38b408fa9 Mon Sep 17 00:00:00 2001 From: puni9869 <80308335+puni9869@users.noreply.github.com> Date: Thu, 27 Jul 2023 19:09:09 +0530 Subject: [PATCH] Add tooltip to describe LFS table column and color `delete LFS file` button red (#26181) Fix: https://github.com/go-gitea/gitea/issues/26152 Thease changes are related to UX and accessibility changes in desktop mode. <img width="50" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/30a75b50-4f8d-4108-9219-2c69b2a8fa6f"> Also this is incomplete header <img width="264" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/87837076-dfc7-4a68-863a-795edf61eb02"> Lets add a tooltip if it is applicable or add `title` attribute so that it will be clearly visible. After   --- templates/repo/settings/lfs.tmpl | 4 ++-- templates/repo/settings/lfs_pointers.tmpl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/templates/repo/settings/lfs.tmpl b/templates/repo/settings/lfs.tmpl index 0d3a618e8d..c4c27dce64 100644 --- a/templates/repo/settings/lfs.tmpl +++ b/templates/repo/settings/lfs.tmpl @@ -20,8 +20,8 @@ <td>{{TimeSince .CreatedUnix.AsTime $.locale}}</td> <td class="right aligned"> <a class="ui primary button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a> - <button class="ui basic show-modal icon button" data-modal="#delete-{{.Oid}}"> - <span class="btn-octicon btn-octicon-danger" data-tooltip-content="{{$.locale.Tr "repo.editor.delete_this_file"}}">{{svg "octicon-trash"}}</span> + <button class="ui basic show-modal icon button red" data-modal="#delete-{{.Oid}}"> + <span class="btn-octicon btn-octicon-danger" data-tooltip-content="{{$.locale.Tr "repo.editor.delete_this_file"}}">{{svg "octicon-trash"}}</span> </button> </td> </tr> diff --git a/templates/repo/settings/lfs_pointers.tmpl b/templates/repo/settings/lfs_pointers.tmpl index 0fffdadc3f..b6b58a3772 100644 --- a/templates/repo/settings/lfs_pointers.tmpl +++ b/templates/repo/settings/lfs_pointers.tmpl @@ -24,7 +24,7 @@ <th class="four wide">{{.locale.Tr "repo.settings.lfs_pointers.oid"}}</th> <th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.inRepo"}}</th> <th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.exists"}}</th> - <th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}</th> + <th class="two wide" data-tooltip-content="{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}">{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}</th> <th class="three wide"></th> </tr> </thead>