From 0731abc44441048079444ba3d83eaeacc4814ed7 Mon Sep 17 00:00:00 2001
From: wxiaoguang <wxiaoguang@gmail.com>
Date: Mon, 21 Aug 2023 23:00:14 +0800
Subject: [PATCH] Remove avatarHTML from template helpers (#26598)
The HTML code is more readable and more correct (it needs `"ui avatar"`
class)
Co-authored-by: Giteabot <teabot@gitea.io>
---
modules/templates/helper.go | 1 -
templates/user/dashboard/feeds.tmpl | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/modules/templates/helper.go b/modules/templates/helper.go
index 8fedc4076a..bb1411cbfd 100644
--- a/modules/templates/helper.go
+++ b/modules/templates/helper.go
@@ -53,7 +53,6 @@ func NewFuncMap() template.FuncMap {
// -----------------------------------------------------------------
// svg / avatar / icon
"svg": svg.RenderHTML,
- "avatarHTML": AvatarHTML,
"EntryIcon": base.EntryIcon,
"MigrationIcon": MigrationIcon,
"ActionIcon": ActionIcon,
diff --git a/templates/user/dashboard/feeds.tmpl b/templates/user/dashboard/feeds.tmpl
index 24768439f5..aad44f57df 100644
--- a/templates/user/dashboard/feeds.tmpl
+++ b/templates/user/dashboard/feeds.tmpl
@@ -86,7 +86,7 @@
{{range $push.Commits}}
{{$commitLink := printf "%s/commit/%s" $repoLink .Sha1}}
<div class="flex-item">
- {{avatarHTML ($push.AvatarLink $.Context .AuthorEmail) 16 "" .AuthorName}}
+ <img class="ui avatar" src="{{$push.AvatarLink $.Context .AuthorEmail}}" title="{{.AuthorName}}" width="16" height="16">
<a class="commit-id" href="{{$commitLink}}">{{ShortSha .Sha1}}</a>
<span class="text truncate light grey">
{{RenderCommitMessage $.Context .Message $repoLink $.ComposeMetas}}