From 068e96fbd25e2ea683d1f7d51cb43ab9b5f82356 Mon Sep 17 00:00:00 2001
From: Christian Ullrich <chris@chrullrich.net>
Date: Mon, 19 Dec 2022 13:48:57 +0100
Subject: [PATCH] Do not list active repositories as unadopted (#22034)
(#22167)
Backport #22034
This fixes a bug where, when searching unadopted repositories, active
repositories will be listed as well. This is because the size of the
array of repository names to check is larger by one than the
`IterateBufferSize`.
For an `IterateBufferSize` of 50, the original code will pass 51
repository names but set the query to `LIMIT 50`. If all repositories in
the query are active (i.e. not unadopted) one of them will be omitted
from the result. Due to the `ORDER BY` clause it will be the oldest (or
least recently modified) one.
Co-authored-by: Christian Ullrich <christian.ullrich@traditionsa.lu>
---
services/repository/adopt.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/services/repository/adopt.go b/services/repository/adopt.go
index 0df0aa049b..46050cc5e4 100644
--- a/services/repository/adopt.go
+++ b/services/repository/adopt.go
@@ -340,7 +340,7 @@ func ListUnadoptedRepositories(query string, opts *db.ListOptions) ([]string, in
}
repoNamesToCheck = append(repoNamesToCheck, name)
- if len(repoNamesToCheck) > setting.Database.IterateBufferSize {
+ if len(repoNamesToCheck) >= setting.Database.IterateBufferSize {
if err = checkUnadoptedRepositories(userName, repoNamesToCheck, unadopted); err != nil {
return err
}