serv/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-01-08 11:58:49 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

proxy: fix TestReverseProxy failure on go tip (#1360)

Browse source 
Because of this commit(6e36811c37399d60cbce587b7c48e611009c5aec) on go tip,
it will probe the request's body to determine whether to use chunked transfer
encoding which trailers depend on it.
So we just offer a non empty body to make trailers work.

fix issue #1359

Signed-off-by: Tw <tw19881113@gmail.com>
This commit is contained in:
Tw 2017-01-19 06:34:25 +08:00 committed by Matt Holt
parent 6bac558c98
commit ecf852ea43
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
caddyhttp/proxy/proxy_test.go
View file

@ -78,7 +78,7 @@ func TestReverseProxy(t *testing.T) {
} }
// create request and response recorder // create request and response recorder
r := httptest.NewRequest("GET", "/", nil) r := httptest.NewRequest("GET", "/", strings.NewReader("test"))
w := httptest.NewRecorder() w := httptest.NewRecorder()
r.ContentLength = -1 // force chunked encoding (required for trailers) r.ContentLength = -1 // force chunked encoding (required for trailers)
@ -97,6 +97,7 @@ func TestReverseProxy(t *testing.T) {
verifyHeaders(res.Header, res.Trailer) verifyHeaders(res.Header, res.Trailer)
// Make sure {upstream} placeholder is set // Make sure {upstream} placeholder is set
r.Body = ioutil.NopCloser(strings.NewReader("test"))
rr := httpserver.NewResponseRecorder(httptest.NewRecorder()) rr := httpserver.NewResponseRecorder(httptest.NewRecorder())
rr.Replacer = httpserver.NewReplacer(r, rr, "-") rr.Replacer = httpserver.NewReplacer(r, rr, "-")