headers: Fix + in Caddyfile to properly append rather than set (#4506)

This commit is contained in:
Francis Lavoie 2022-01-04 12:10:11 -05:00 committed by GitHub
parent 3fe2c73dd0
commit e9dde23024
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions

View file

@ -13,6 +13,10 @@
header @images { header @images {
Cache-Control "public, max-age=3600, stale-while-revalidate=86400" Cache-Control "public, max-age=3600, stale-while-revalidate=86400"
} }
header {
+Link "Foo"
+Link "Bar"
}
} }
---------- ----------
{ {
@ -121,6 +125,17 @@
] ]
} }
} }
},
{
"handler": "headers",
"response": {
"add": {
"Link": [
"Foo",
"Bar"
]
}
}
} }
] ]
} }

View file

@ -222,7 +222,7 @@ func applyHeaderOp(ops *HeaderOps, respHeaderOps *RespHeaderOps, field, value, r
if ops.Add == nil { if ops.Add == nil {
ops.Add = make(http.Header) ops.Add = make(http.Header)
} }
ops.Add.Set(field[1:], value) ops.Add.Add(field[1:], value)
case strings.HasPrefix(field, "-"): // delete case strings.HasPrefix(field, "-"): // delete
ops.Delete = append(ops.Delete, field[1:]) ops.Delete = append(ops.Delete, field[1:])