serv/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-28 14:43:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

reverseproxy: always set req.URL.Host with upstream (#3297)

Browse source
This commit is contained in:
westwin 2020-04-22 10:34:00 +08:00 committed by GitHub
parent e3a8f72f1c
commit da8686c4b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
modules/caddyhttp/reverseproxy/reverseproxy.go
View file

@ -613,19 +613,17 @@ func (lb LoadBalancing) tryAgain(start time.Time, proxyErr error, req *http.Requ
// directRequest modifies only req.URL so that it points to the upstream // directRequest modifies only req.URL so that it points to the upstream
// in the given DialInfo. It must modify ONLY the request URL. // in the given DialInfo. It must modify ONLY the request URL.
func (h Handler) directRequest(req *http.Request, di DialInfo) { func (h Handler) directRequest(req *http.Request, di DialInfo) {
if req.URL.Host == "" { // we need a host, so set the upstream's host address
// we need a host, so set the upstream's host address reqHost := di.Address
reqHost := di.Address
// if the port equates to the scheme, strip the port because // if the port equates to the scheme, strip the port because
// it's weird to make a request like http://example.com:80/. // it's weird to make a request like http://example.com:80/.
if (req.URL.Scheme == "http" && di.Port == "80") || if (req.URL.Scheme == "http" && di.Port == "80") ||
(req.URL.Scheme == "https" && di.Port == "443") { (req.URL.Scheme == "https" && di.Port == "443") {
reqHost = di.Host reqHost = di.Host
}
req.URL.Host = reqHost
} }
req.URL.Host = reqHost
} }
// shouldPanicOnCopyError reports whether the reverse proxy should // shouldPanicOnCopyError reports whether the reverse proxy should