serv/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-28 14:43:48 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

reverseproxy: Make debug log safe if error occurs

Browse source
This commit is contained in:
Matthew Holt 2020-05-18 14:08:11 -06:00
parent 812278acd8
commit 9ee01dceac
No known key found for this signature in database
GPG key ID: 2A349DD577D586A5
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/caddyhttp/reverseproxy/reverseproxy.go
View file

@ -461,20 +461,24 @@ func (h *Handler) reverseProxy(rw http.ResponseWriter, req *http.Request, di Dia
// point the request to this upstream // point the request to this upstream
h.directRequest(req, di) h.directRequest(req, di)
// do the round-trip // do the round-trip; emit debug log with values we know are
// safe, or if there is no error, emit fuller log entry
start := time.Now() start := time.Now()
res, err := h.Transport.RoundTrip(req) res, err := h.Transport.RoundTrip(req)
duration := time.Since(start) duration := time.Since(start)
h.logger.Debug("upstream roundtrip", logger := h.logger.With(
zap.String("upstream", di.Upstream.String()), zap.String("upstream", di.Upstream.String()),
zap.Object("request", caddyhttp.LoggableHTTPRequest{Request: req}), zap.Object("request", caddyhttp.LoggableHTTPRequest{Request: req}),
zap.Object("headers", caddyhttp.LoggableHTTPHeader(res.Header)),
zap.Duration("duration", duration), zap.Duration("duration", duration),
zap.Int("status", res.StatusCode),
) )
if err != nil { if err != nil {
logger.Debug("upstream roundtrip", zap.Error(err))
return err return err
} }
logger.Debug("upstream roundtrip",
zap.Object("headers", caddyhttp.LoggableHTTPHeader(res.Header)),
zap.Int("status", res.StatusCode),
)
// update circuit breaker on current conditions // update circuit breaker on current conditions
if di.Upstream.cb != nil { if di.Upstream.cb != nil {