From 99d34f1c1d6a785104252303c9c7744373052342 Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Mon, 9 Mar 2020 00:09:15 -0600 Subject: [PATCH] cmd: Use loadConfig() for validate as run, start, and reload do --- cmd/commandfuncs.go | 29 ++--------------------------- 1 file changed, 2 insertions(+), 27 deletions(-) diff --git a/cmd/commandfuncs.go b/cmd/commandfuncs.go index 8ab90999..12d25868 100644 --- a/cmd/commandfuncs.go +++ b/cmd/commandfuncs.go @@ -492,35 +492,10 @@ func cmdValidateConfig(fl Flags) (int, error) { validateCmdConfigFlag := fl.String("config") validateCmdAdapterFlag := fl.String("adapter") - input, err := ioutil.ReadFile(validateCmdConfigFlag) + input, _, err := loadConfig(validateCmdConfigFlag, validateCmdAdapterFlag) if err != nil { - return caddy.ExitCodeFailedStartup, - fmt.Errorf("reading input file: %v", err) + return caddy.ExitCodeFailedStartup, err } - - if validateCmdAdapterFlag != "" { - cfgAdapter := caddyconfig.GetAdapter(validateCmdAdapterFlag) - if cfgAdapter == nil { - return caddy.ExitCodeFailedStartup, - fmt.Errorf("unrecognized config adapter: %s", validateCmdAdapterFlag) - } - - adaptedConfig, warnings, err := cfgAdapter.Adapt(input, nil) - if err != nil { - return caddy.ExitCodeFailedStartup, err - } - // print warnings to stderr - for _, warn := range warnings { - msg := warn.Message - if warn.Directive != "" { - msg = fmt.Sprintf("%s: %s", warn.Directive, warn.Message) - } - fmt.Fprintf(os.Stderr, "[WARNING][%s] %s:%d: %s\n", validateCmdAdapterFlag, warn.File, warn.Line, msg) - } - - input = adaptedConfig - } - input = caddy.RemoveMetaFields(input) var cfg *caddy.Config