mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-27 06:03:48 +03:00
reverseproxy: Use correct cases for websocket related headers (#6621)
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
This commit is contained in:
parent
030b6051f1
commit
93ec641d5d
1 changed files with 25 additions and 0 deletions
|
@ -573,6 +573,30 @@ func (h *Handler) proxyLoopIteration(r *http.Request, origReq *http.Request, w h
|
||||||
return false, proxyErr
|
return false, proxyErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Mapping of the canonical form of the headers, to the RFC 6455 form,
|
||||||
|
// i.e. `WebSocket` with uppercase 'S'.
|
||||||
|
var websocketHeaderMapping = map[string]string{
|
||||||
|
"Sec-Websocket-Accept": "Sec-WebSocket-Accept",
|
||||||
|
"Sec-Websocket-Extensions": "Sec-WebSocket-Extensions",
|
||||||
|
"Sec-Websocket-Key": "Sec-WebSocket-Key",
|
||||||
|
"Sec-Websocket-Protocol": "Sec-WebSocket-Protocol",
|
||||||
|
"Sec-Websocket-Version": "Sec-WebSocket-Version",
|
||||||
|
}
|
||||||
|
|
||||||
|
// normalizeWebsocketHeaders ensures we use the standard casing as per
|
||||||
|
// RFC 6455, i.e. `WebSocket` with uppercase 'S'. Most servers don't
|
||||||
|
// care about this difference (read headers case insensitively), but
|
||||||
|
// some do, so this maximizes compatibility with upstreams.
|
||||||
|
// See https://github.com/caddyserver/caddy/pull/6621
|
||||||
|
func normalizeWebsocketHeaders(header http.Header) {
|
||||||
|
for k, rk := range websocketHeaderMapping {
|
||||||
|
if v, ok := header[k]; ok {
|
||||||
|
delete(header, k)
|
||||||
|
header[rk] = v
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// prepareRequest clones req so that it can be safely modified without
|
// prepareRequest clones req so that it can be safely modified without
|
||||||
// changing the original request or introducing data races. It then
|
// changing the original request or introducing data races. It then
|
||||||
// modifies it so that it is ready to be proxied, except for directing
|
// modifies it so that it is ready to be proxied, except for directing
|
||||||
|
@ -643,6 +667,7 @@ func (h Handler) prepareRequest(req *http.Request, repl *caddy.Replacer) (*http.
|
||||||
if reqUpType != "" {
|
if reqUpType != "" {
|
||||||
req.Header.Set("Connection", "Upgrade")
|
req.Header.Set("Connection", "Upgrade")
|
||||||
req.Header.Set("Upgrade", reqUpType)
|
req.Header.Set("Upgrade", reqUpType)
|
||||||
|
normalizeWebsocketHeaders(req.Header)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Set up the PROXY protocol info
|
// Set up the PROXY protocol info
|
||||||
|
|
Loading…
Reference in a new issue