From 6fb98ba1880d5f3f6ede4f407b0c9f80f7c7daa6 Mon Sep 17 00:00:00 2001
From: Mohammed Al Sahaf <msaa1990@gmail.com>
Date: Thu, 27 Feb 2020 03:51:54 +0300
Subject: [PATCH] ci: improve CI flow (#3083)

* ci: update golangci-lint
* ci: build Caddy to catch build error
* ci: remove GO111MODULE env var
* ci: update MacOS image
---
 azure-pipelines.yml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index d1dfb6b72..808a532ac 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -17,8 +17,6 @@ variables:
   GOPATH: $(system.defaultWorkingDirectory)/gopath
   GOBIN:  $(GOPATH)/bin
   modulePath: '$(GOPATH)/src/github.com/$(build.repository.name)'
-  # TODO: Remove once it's enabled by default
-  GO111MODULE: on
 
 jobs:
 - job: crossPlatformTest
@@ -29,7 +27,7 @@ jobs:
         imageName: ubuntu-16.04
         gorootDir: /usr/local
       mac:
-        imageName: macos-10.13
+        imageName: macos-10.14
         gorootDir: /usr/local
       windows:
         imageName: windows-2019
@@ -78,7 +76,7 @@ jobs:
     condition: eq( variables['Agent.OS'], 'Windows_NT' )
     displayName: Install Go on Windows
 
-  - bash: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
+  - bash: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.6
     displayName: Install golangci-lint
 
   - script: |
@@ -102,6 +100,10 @@ jobs:
     workingDirectory: '$(modulePath)'
     displayName: Get dependencies
 
+  - bash: go build -v
+    workingDirectory: '$(modulePath)/cmd/caddy'
+    displayName: Build Caddy
+
   # its behavior is governed by .golangci.yml
   - script: |
       (golangci-lint run --out-format junit-xml) > test-results/lint-result.xml