serv/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-01-22 10:25:46 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed panic due to 0-length buffers being passed to io.CopyBuffer

Browse source
This commit is contained in:
Leonard Hecker 2016-12-26 20:42:00 +01:00
parent 6352c9054a
commit 53635ba538
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
caddyhttp/proxy/reverseproxy.go
View file

@ -253,7 +253,7 @@ func (rp *ReverseProxy) ServeHTTP(rw http.ResponseWriter, outreq *http.Request,
} }
func (rp *ReverseProxy) copyResponse(dst io.Writer, src io.Reader) { func (rp *ReverseProxy) copyResponse(dst io.Writer, src io.Reader) {
buf := bufferPool.Get() buf := bufferPool.Get().([]byte)
defer bufferPool.Put(buf) defer bufferPool.Put(buf)
if rp.FlushInterval != 0 { if rp.FlushInterval != 0 {
@ -268,7 +268,10 @@ func (rp *ReverseProxy) copyResponse(dst io.Writer, src io.Reader) {
dst = mlw dst = mlw
} }
} }
io.CopyBuffer(dst, src, buf.([]byte))
// `CopyBuffer` only uses `buf` up to it's length and
// panics if it's 0 => Extend it's length up to it's capacity.
io.CopyBuffer(dst, src, buf[:cap(buf)])
} }
// skip these headers if they already exist. // skip these headers if they already exist.