Merge pull request #1734 from tw4452852/ineffassign

markdown: fix the real ineffectual assignments in test
This commit is contained in:
Matt Holt 2017-06-29 08:28:57 -06:00 committed by GitHub
commit 4750699ab0

View file

@ -81,17 +81,14 @@ func TestMarkdown(t *testing.T) {
req, err := http.NewRequest("GET", url, nil)
if err != nil {
t.Fatalf("Could not create HTTP request: %v", err)
return ""
}
rec := httptest.NewRecorder()
code, err := md.ServeHTTP(rec, req)
if err != nil {
t.Fatal(err)
return ""
}
if code != http.StatusOK {
t.Fatalf("Wrong status, expected: %d and got %d", http.StatusOK, code)
return ""
}
return rec.Body.String()
}
@ -117,6 +114,10 @@ Welcome to A Caddy website!
</body>
</html>
`
if respBody != expectedBody {
t.Fatalf("Expected body:\n%q\ngot:\n%q", expectedBody, respBody)
}
respBody = get("/docflags/test.md")
expectedBody = `Doc.var_string hello
Doc.var_bool true
@ -226,11 +227,9 @@ func TestTemplateReload(t *testing.T) {
code, err := md.ServeHTTP(rec, req)
if err != nil {
t.Fatal(err)
return ""
}
if code != http.StatusOK {
t.Fatalf("Wrong status, expected: %d and got %d", http.StatusOK, code)
return ""
}
return rec.Body.String()
}