serv/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-26 13:43:47 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: Fix bug in AppIfConfigured (fix #6336)

Browse source
This commit is contained in:
Matthew Holt 2024-05-22 18:47:03 -06:00
parent 61917c3443
commit 2ce5c65269
No known key found for this signature in database
GPG key ID: 2A349DD577D586A5
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
context.go
View file

@ -455,20 +455,27 @@ func (ctx Context) App(name string) (any, error) {
// AppIfConfigured is like App, but it returns an error if the // AppIfConfigured is like App, but it returns an error if the
// app has not been configured. This is useful when the app is // app has not been configured. This is useful when the app is
// required and its absence is a configuration error, or when // required and its absence is a configuration error; or when
// the app is optional and you don't want to instantiate a // the app is optional and you don't want to instantiate a
// new one that hasn't been explicitly configured. // new one that hasn't been explicitly configured. If the app
// is not in the configuration, the error wraps ErrNotConfigured.
func (ctx Context) AppIfConfigured(name string) (any, error) { func (ctx Context) AppIfConfigured(name string) (any, error) {
if ctx.cfg == nil {
return nil, fmt.Errorf("app module %s: %w", name, ErrNotConfigured)
}
if app, ok := ctx.cfg.apps[name]; ok { if app, ok := ctx.cfg.apps[name]; ok {
return app, nil return app, nil
} }
appRaw := ctx.cfg.AppsRaw[name] appRaw := ctx.cfg.AppsRaw[name]
if appRaw == nil { if appRaw == nil {
return nil, fmt.Errorf("app module %s is not configured", name) return nil, fmt.Errorf("app module %s: %w", name, ErrNotConfigured)
} }
return ctx.App(name) return ctx.App(name)
} }
// ErrNotConfigured indicates a module is not configured.
var ErrNotConfigured = fmt.Errorf("module not configured")
// Storage returns the configured Caddy storage implementation. // Storage returns the configured Caddy storage implementation.
func (ctx Context) Storage() certmagic.Storage { func (ctx Context) Storage() certmagic.Storage {
return ctx.cfg.storage return ctx.cfg.storage