remove VM.Stack() function

runtime/vm.go

@@ -699,6 +699,11 @@ func (v *VM) Run() error {
 		}
 	}
 
+	// check if stack still has some objects left
+	if v.sp > 0 && !v.aborting {
+		return fmt.Errorf("non empty stack after execution")
+	}
+
 	return nil
 }
 
@@ -706,13 +711,7 @@ func (v *VM) Globals() []*objects.Object {
 	return v.globals
 }
 
-// for tests
-func (v *VM) Stack() []*objects.Object {
-	return v.stack[:v.sp]
-}
-
-// for tests
-func (v *VM) FrameDebug() (frameIndex int, ip int) {
+func (v *VM) FrameInfo() (frameIndex int, ip int) {
 	return v.framesIndex - 1, v.frames[v.framesIndex-1].ip
 }
 

runtime/vm_test.go

@@ -1,7 +1,6 @@
 package runtime_test
 
 import (
-	"errors"
 	"fmt"
 	"reflect"
 	_runtime "runtime"
@@ -148,7 +147,7 @@ func traceCompileRun(file *ast.File, symbols map[string]objects.Object) (res map
 
 			var ipstr string
 			if v != nil {
-				frameIdx, ip := v.FrameDebug()
+				frameIdx, ip := v.FrameInfo()
 				ipstr = fmt.Sprintf("\n  (Frame=%d, IP=%d)", frameIdx, ip)
 			}
 			trace = append(trace, fmt.Sprintf("[Panic]\n\n  %v%s\n", e, ipstr))
@@ -217,31 +216,11 @@ func traceCompileRun(file *ast.File, symbols map[string]objects.Object) (res map
 			}
 		}
 		trace = append(trace, fmt.Sprintf("\n[Globals]\n\n%s", strings.Join(globalsStr, "\n")))
-		var stack []string
-		for sidx, s := range v.Stack() {
-			if s == nil {
-				continue
-			}
-
-			if cmFn, ok := (*s).(*objects.Closure); ok {
-				stack = append(stack, fmt.Sprintf("[% 3d] (Closure|%p)", sidx, s))
-				for _, l := range compiler.FormatInstructions(cmFn.Fn.Instructions, 0) {
-					stack = append(stack, fmt.Sprintf("     %s", l))
-				}
-			} else {
-				stack = append(stack, fmt.Sprintf("[% 3d] %s (%s|%p)", sidx, *s, reflect.TypeOf(*s).Name(), s))
-			}
-		}
-		trace = append(trace, fmt.Sprintf("\n[Stack]\n\n%s", strings.Join(stack, "\n")))
 	}
 	if err != nil {
 		return
 	}
 
-	if len(v.Stack()) > 0 {
-		err = errors.New("value left in the stack")
-	}
-
 	return
 }